1536392 - Perma [tier2] layout/style/test/test_animations_omta.html | transform-like properties on compositor at 5s: should be animating on compositor

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P5)

Description

[Treeherder Bug Filer]

#[markdown(off)]
Filed by: ccoroiu [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=234722559&repo=autoland

https://queue.taskcluster.net/v1/task/Ot_rBAuPRsqhIfB8Dj-DAw/runs/0/artifacts/public/logs/live_backing.log

[task 2019-03-19T09:09:50.219Z] 09:09:50 INFO - 1885 INFO TEST-PASS | layout/style/test/test_animations_omta.html | transform-like properties transition runs on compositor thread - got matrix(1, 0, 0, 1, 300, 0), expected matrix(1, 0, 0, 1, 300, 0)
[task 2019-03-19T09:09:50.219Z] 09:09:50 INFO - Buffered messages finished
[task 2019-03-19T09:09:50.219Z] 09:09:50 INFO - 1886 INFO TEST-UNEXPECTED-FAIL | layout/style/test/test_animations_omta.html | transform-like properties on compositor at 5s: should be animating on compositor
[task 2019-03-19T09:09:50.219Z] 09:09:50 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
[task 2019-03-19T09:09:50.219Z] 09:09:50 INFO - window.omta_is_approx@layout/style/test/animation_utils.js:487:11
[task 2019-03-19T09:09:50.219Z] 09:09:50 INFO - window[fn]@layout/style/test/test_animations_omta.html:199:19
[task 2019-03-19T09:09:50.219Z] 09:09:50 INFO - window.omta_is@layout/style/test/animation_utils.js:415:12
[task 2019-03-19T09:09:50.219Z] 09:09:50 INFO - window[fn]@layout/style/test/test_animations_omta.html:199:19
[task 2019-03-19T09:09:50.219Z] 09:09:50 INFO - @layout/style/test/test_animations_omta.html:2602:3

Comment 1

[Cristina Coroiu [:ccoroiu]]

Started to perma fail:
https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=android%2C7.0%2Cx86-64%2Copt%2Cmochitests%2Cwith%2Ce10s%2Ctest-android-em-7.0-x86_64%2Fopt-mochitest-e10s-4%2Cm-e10s%284%29&revision=08126c1f53fe82ab685bd3e75e97ce7bf516a3d9&selectedJob=234729442

:boris can you please take a look?

Comment 2

[Boris Chiou [:boris]]

(In reply to Cristina Coroiu [:ccoroiu] from comment #1)

Started to perma fail:
https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=android%2C7.0%2Cx86-64%2Copt%2Cmochitests%2Cwith%2Ce10s%2Ctest-android-em-7.0-x86_64%2Fopt-mochitest-e10s-4%2Cm-e10s%284%29&revision=08126c1f53fe82ab685bd3e75e97ce7bf516a3d9&selectedJob=234729442

:boris can you please take a look?

Thanks for notifying me and sorry about this. I'm looking at this right now.

Comment 3

[Boris Chiou [:boris]]

It seems getOMTAStyle(transform) failed if we have a multiple transform-like properties animation and advance it to 50% (i.e. 5s).

I follow the steps from the email in dev-platform to build the Android 7.0 x86_64 opt and run this test with GeckoView (e10s):

1. Build for Android x86-64 (mozconfig with ac_add_options --target=x86_64)
2. Run Android: ./mach android-emulator --version x86-7.0
3. Install the Geckoview androidTest apk
   • ./mach android archive-geckoview
   • ./mach gradle geckoview:installWithGeckoBinariesDebugAndroidTest
   • adb shell pm list packages org.mozilla.package:org.mozilla.geckoview.test
4. ./mach test layout/style/test/test_animations_omta.html --app=org.mozilla.geckoview.test

Unfortunately, I cannot reproduce this failure on my local machine, and this makes it hard to debug this problem. So I decide to temporary disable this test case (only on GeckoView). (Maybe the steps I followed are not correct.)

Comment 4

[Boris Chiou [:boris]]

Attachment: Bug 1536392 - Disable multiple transform-like properties animation at 5s on GeckoView.

If we have an animation with multiple transform-like properties, it
seems getOMTAStyle(transform) returns an empty string at 50% on
Android x86_64 opt with e10s, so we cannot pass this test case. We
temporarily disable this test case on this platform.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/993bbf845ef0
Disable multiple transform-like properties animation at 5s on GeckoView. r=hiro

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Probably this is somewhat related to bug 1526847.

Comment 7

[Intermittent Failures Robot]

128 failures in 512 pushes (0.25 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 121
• mozilla-central: 3
• mozilla-inbound: 4

Platform breakdown:

• android-em-7-0-x86_64: 128

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1536392&startday=2019-03-19&endday=2019-03-19&tree=all

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/993bbf845ef0

Comment 9

[Intermittent Failures Robot]

130 failures in 2561 pushes (0.051 failures/push) were associated with this bug in the last 7 days.

This is the #16 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 122
• mozilla-central: 3
• mozilla-inbound: 5

Platform breakdown:

• android-em-7-0-x86_64: 130

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1536392&startday=2019-03-18&endday=2019-03-24&tree=all

Comment 10

[Hiroyuki Ikezoe (:hiro)]

I think now I know the failure reason. The reason is probably that the result transformed position at 5s is outside of the display port. I've pushed a try with tweaking the transform value, let's see the result.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=40d436adcc76d64c6db18a57ff7d23cd883b7420

Comment 11

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1536392 - Make the transform transition opposite direction of the translate transition to make sure the transformed results is inside the display port. r?boris

Comment 12

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1536392 - Drop GeckoView checks for individual transform properties cases. r?boris

Now all test cases for individual transform properties work fine on GeckoView.

Depends on D47200

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b55e3a5434e
Make the transform transition opposite direction of the translate transition to make sure the transformed results is inside the display port. r=boris
https://hg.mozilla.org/integration/autoland/rev/049de73fed5c
Drop GeckoView checks for individual transform properties cases. r=boris

Comment 14

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8b55e3a5434e
https://hg.mozilla.org/mozilla-central/rev/049de73fed5c