1536427 - Blank Debugger panel when using remote debugging

Status: VERIFIED FIXED

(DevTools :: about:debugging, defect, P1)

Description

[Julian Descottes [:jdescottes]]

Spotted in Bug 1533729

Similar symptoms to Bug 1530861. The debugger panel is completely blank when debugging Fx 66 from Fx 67 or newer. Probably a new regression that happened just before the merge, since the debugger was working 2 weeks ago when we fixed 1530861.

STRs:

• setup remote debugging from Fx 67 to Fx 68 (https://gist.github.com/juliandescottes/b0d3d83154d9ea8a84db5d32aa35d2c1 )
• inspect a remote tab in about:debugging
• select the debugger

ER: Debugger UI should be displayed
AR: Debugger UI is blank

Comment 1

[Julian Descottes [:jdescottes]]

Alex, Jason, any idea what could have triggered this?

The error is

error: "unrecognizedPacketType"
​
from: "server1.conn2.child8/context71"
​
message: "Actor server1.conn2.child8/context71 does not recognize the packet type pauseOnExceptions"

Comment 2

[Jason Laster [:jlast]]

Julian, we recently switched how pause on exceptions are set on the server. It used to be part of the resume packet. https://bugzilla.mozilla.org/show_bug.cgi?id=1532791

Comment 3

[Julian Descottes [:jdescottes]]

Thanks! And thanks for walking through the diff with me, I'll try to put a patch up for review.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1536427 - Stop calling actions.pauseOnExceptions on Debugger startup;r=jlast

Comment 5

[Julian Descottes [:jdescottes]]

Could not spot any regression related to removing the call to loadOnPrefs. I did find a small issue with pause on exceptions, but it seems it's not a regression. Filed https://github.com/firefox-devtools/debugger/issues/8143 for it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a35904d1c1d
Stop calling actions.pauseOnExceptions on Debugger startup;r=jlast

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/6a35904d1c1d

Comment 8

[Julian Descottes [:jdescottes]]

ni? to uplift this after some time on Nightly

Comment 9

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 68.0a1 on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 16.04 x64.
I confirm that the debugger panel isn't blank anymore when debugging Fx66 from Fx67 or newer.

Comment 10

[Julian Descottes [:jdescottes]]

Comment on attachment 9052211 [details]
Bug 1536427 - Stop calling actions.pauseOnExceptions on Debugger startup;r=jlast

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1532791
• User impact if declined: Users cannot use the Debugger when remote debugging Fx 66 from DevEdition 67
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See STRs in summary.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple javascript fix, devtools only, no issue raised on Nightly since the fix landed.
• String changes made/needed:

Comment 11

[Brindusa Tot, Desktop QA]

Since this bug has steps for QA, updating the qe-verify flag.

Comment 12

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9052211 [details]
Bug 1536427 - Stop calling actions.pauseOnExceptions on Debugger startup;r=jlast

Safe fix for a 67 devtools regression, fix verified on Nightly and baked there for a week, uplift approved for 67 beta 6, thanks.

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c9e5b98d97c9

Comment 15

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox 67.0b6 on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 16.04 x64.