1536450 - Make MacroAssembler::getStackPointer non-static

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Reviewbot is getting grumpy with [clang-tidy: readability-static-accessed-through-instance] because we use masm.getStackPointer() all over the place.

While this is defined static on a bunch of our platforms, it is non-static on ARM64 I believe, and so we -need- to be using it as an instance method.

We should just make getStackPointer non-static everywhere.

Comment 1

[Lars T Hansen [:lth]]

Probably worth noting here that getStackPointer() can't be moved into MacroAssembler.h because the return type is not the same on every platform: on ARM64 it's the magic platform-private type RegisterOrSP, on other platforms it's just Register.

Comment 2

[Lars T Hansen [:lth]]

Attachment: Bug 1536450 - Make getStackPointer non-static everywhere. r?mgaudet

getStackPointer is non-static on arm64 so accesses must be via member access: masm.getStackPointer.
But it is static on other platforms, so the member access ticks off the static checkers.
Just make it non-static everywhere; it'll get inlined and boil away in any case.

Comment 3

[Lars T Hansen [:lth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=aaef930141a4ec67f6d25d501ef25efb2bc60816

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f62d77fd228
Make getStackPointer non-static everywhere.  r=mgaudet

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9f62d77fd228