1536467 - TypeError: this.populateSendTabToDevicesMenu is not a function when opening "send tab to device" early enough on startup (no sync has happened yet)

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[:Gijs (he/him)]

The callback situation here presumably means this is no longer bound correctly.

STR:

0. enable session restore
1. sign into sync
2. ensure there's another device in your sync account
3. open a page you can "send to device"
4. restart
5. quickly open the account menu, click "send tab to device"

ER:

Initially it displays "Syncing devices..." and then it shows the devices

AR:
it never shows devices until you close and reopen.

Comment 1

[Vijay Budhram]

Attachment: Bug 1536467 - bind callbacks to `this` for Send Tab to Device subview so they work when we're waiting for the initial sync

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4dedf93bfe2d
bind callbacks to `this` for Send Tab to Device subview so they work when we're waiting for the initial sync r=Gijs

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/4dedf93bfe2d

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/3876472b3140

Comment 5

[Anca Soncutean, Desktop QA]

I’ve reproduced this issue on Nightly 68.0a1 (2019-03-18) with Windows 10 x64.
The issue is verified fixed on Nightly 68.0a1 (2019-04-08) and Beta 67.0b9 with Windows 10 x64, macOS 10.13 and Ubuntu 18.04 x64.