1536471 - Consolidate calls to nsISHEntry::GetChildAt

Status: RESOLVED FIXED

(Core :: DOM: Navigation, enhancement, P2)

Comment 1

[Anny Gakhokidze [:annyG]]

I changed the bug description as we realized that nsISHistory::RemoveEntries is in the parent process already.

Comment 2

[Anny Gakhokidze [:annyG]]

Attachment: Bug 1536471 - Write tests for nsISHistory::RemoveFrameEntries,

Comment 3

[Anny Gakhokidze [:annyG]]

Attachment: Bug 1536471 - Consolidate calls to nsISHEntry::GetChildAt in nsDocShell::AddToSessionHistory by adding nsSHEntry::ClearEntry method,

Currently, nsDocShell repeatedly calls nsISHEntry::GetChildAt and
nsISHEntry::RemoveChild in nsDocShell::AddToSessionHistory,
which results in twice as many IPC calls as the number of children
a session history entry has. Additionally, there is one extra
IPC sync call to nsISHEntry::AbandonBFCacheEntry after the loop.

With the proposed solution, there will only be 1 sync IPC call.

Depends on D24977

Comment 4

[Anny Gakhokidze [:annyG]]

Attachment: Bug 1536471 - Consolidate calls to nsISHEntry::GetChildAt in nsDocShell::ClearFrameHistory by adding a new sync IPC call nsISHistory::RemoveFrameEntries,

Currently, nsDocShell repeatedly calls nsISHEntry::GetChildAt, which
results in as many IPC sync calls as the number of children
a session history entry has. Calling nsISHEntry::GetChildCount
and ChildSHistory::LEgacySHistory::RemoveEntries incurs additional
extra 2 sync IPC calls.

With the proposed solution, there will only be 1 sync IPC call.

Comment 5

[Neha Kochar [:neha]]

Pushed to ash branch:
https://hg.mozilla.org/projects/ash/rev/3f4a092d8f6544a212ee8a80d9275ae68c6446d1
https://hg.mozilla.org/projects/ash/rev/b081ebe7b3f52dec2a85e744b2dd2a4b0f344f8e
https://hg.mozilla.org/projects/ash/rev/0270d6b952ffa1704690c777c55fcaed30125b38

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c45890e566b
Consolidate calls to nsISHEntry::GetChildAt in nsDocShell::ClearFrameHistory by adding a new sync IPC call nsISHistory::RemoveFrameEntries, r=peterv, r=nika for adding sync IPC messages
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d5396434bb4
Write tests for nsISHistory::RemoveFrameEntries, r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5388b03ad03
Consolidate calls to nsISHEntry::GetChildAt in nsDocShell::AddToSessionHistory by adding nsSHEntry::ClearEntry method, r=peterv, r=nika for adding sync IPC messages

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4c45890e566b
https://hg.mozilla.org/mozilla-central/rev/8d5396434bb4
https://hg.mozilla.org/mozilla-central/rev/d5388b03ad03