1536473 - ext-menus onWindowOpen listener triggers 'this._box is null' exception on every new window opened

Status: VERIFIED FIXED

(WebExtensions :: Frontend, enhancement)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

I'm not sure if this exception is also actually breaking any expected behavior (e.g. for the menus API), nevertheless browser-sidebar.js is throwing and so it sounds like something that we should fix.

The code that is triggering the exception has been introduced in Bug 1419195, in particular where it is accessing window.SidebarUI.currentID right after a new window has been opened.

My guess is that the error is raised because the SidebarUI may not be yet initialized on the new window when the currentID getter is accessed.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1536473 - ext-menu onWindowOpen handler should wait for SidebarUI to be fully initialized. r?mixedpuppy!,Gijs!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d974001a427e
ext-menu onWindowOpen handler should wait for SidebarUI to be fully initialized. r=mixedpuppy,Gijs

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/d974001a427e

Comment 4

[Madalin Cotetiu]

Can you please provide some STR for this issue so we can check it manually? If no manual testing is needed please mark it as "qe-verify- "

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

I'm not sure what was the exact STR to trigger the error message 'this._box is null' (and if there was any additional side-effect of this issue besides the error logged in the console), but it may be good to verify manually given that the patch doesn't include any new automated test.

Madalin, Would you mind to try the following STR:

• open the browser console
• then open some new windows (both non-private and private windows)
• look in the browser console for the 'this._box is null' error.

Comment 6

[Madalin Cotetiu]

I have done some exploratory testing following the above steps using the latest nightly on Win7x64, Mac OS X 10.14.1 and In was not able to reproduce the issue. I'm marking the bug as verified fixed.