1536540 - Implement IDBCursor request attribute

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, enhancement, P3)

Description

[Andrew Sutherland [:asuth] (he/him)]

On https://github.com/w3c/IndexedDB/issues/255 with spec changes in https://github.com/w3c/IndexedDB/pull/257 the plan is to add a request attribute to IDBCursor for consistency and to make it easier for magic wrappers.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug and there is no activity for 2 weeks.
:overholt, could you have a look please?

Comment 2

[Julien Wajsberg [:julienw]]

Hey Andrew, is that difficult work? If not too difficult, maybe we could make it a mentored bug, what do you think?

Comment 3

[Simon Giesecke [:sg] [he/him]]

Julien, I will give it a look. I guess it isn't difficult.

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1536540 - Implement IDBCursor.request attribute. r=#dom-workers-and-storage

Comment 5

[Simon Giesecke [:sg] [he/him]]

I submitted a patch.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7dccafbf3437
Implement IDBCursor.request attribute. r=dom-workers-and-storage-reviewers,janv,webidl,baku

Comment 7

[Andreea Pavel [:apavel]]

Backed out for failing wpt at idlharness.any.worker.html

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=7dccafbf3437d70dd969663b04536a98e097c4f8&selectedJob=298886962

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298886962&repo=autoland&lineNumber=18637

Backout: https://hg.mozilla.org/integration/autoland/rev/0412b36eb5e4a53fbf779a68da12d4ef1eafb89c

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07f277f3030f
Implement IDBCursor.request attribute. r=dom-workers-and-storage-reviewers,janv,webidl,baku

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/07f277f3030f

Comment 10

[Simon Giesecke [:sg] [he/him]]

Clearing ni, since this has successfully landed now.

Comment 11

[Chris Mills [:cmills]]

Hi Simon, I'm updating the MDN docs to include this, and it doesn't look like cursor.request is returning anything, when I test it (it works as expected in Chrome). This isn't behind a pref or something, is it?

Comment 12

[Chris Mills [:cmills]]

Oops, I'm sorry, I didn't have my Nighty up-to-date! Ignore me ;-)

Comment 13

[Chris Mills [:cmills]]

OK, docs updates completed for this one; see https://github.com/mdn/sprints/issues/3244#issuecomment-630119534 for the full details.