1536582 - Generate Servo_ binding functions using cbindgen.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Err, bug description should read:

This should massively simplify the amount of boilerplate needed to tweak and add new ffi functions, which is always a pain. It should also improve buildtimes by virtue of avoiding running bindgen twice, but we could do that in other ways I guess.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1536582 - Autogenerate Servo_ binding functions with cbindgen. r=#style

This depends on https://github.com/eqrion/cbindgen/pull/308. Other than that,
this should be ready to go.

There's still a bit more magic than what I'd like to eventually. I should be
able to make cbindgen not rename types if it doesn't know about them, or
something.

But this removes most of the manual binding function implementations (all but
the ones that are declared via macros, which cbindgen doesn't see across).

I need to give up on the _Drop functions taking an Owned<T> because of
instantiation order fiasco. In order to define DefaultDelete I need Owned to be
complete, but I cannot do it after including the generated file since some
declarations already instantiate the specialization. Oh well.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1536582 - Update cbindgen. r=#style

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdbf6856c91a
Update cbindgen. r=boris

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4600398650aa
Autogenerate Servo_ binding functions with cbindgen. r=boris

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/bdbf6856c91a
https://hg.mozilla.org/mozilla-central/rev/4600398650aa