1536666 - Implement assertions that dbg objects we are handling are owned by the thread actor's debugger

Status: NEW

(DevTools :: Debugger, task, P3)

Description

[Logan Smyth [:loganfsmyth]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1536618 could easily have been caught before it landed if we could assert that a given object is owned by the thread actor's debugger up front when the source actor is created, instead of waiting for things to throw when we call findScripts.

Comment 1

[Brian Hackett [Laid off!]]

I guess at a more basic level, what is the rationale behind allowing multiple Debuggers to exist for a thread? The Debugger for the thread actor is easy to access, and having other debuggers hanging around which can't interoperate seems like something of a footgun.

Comment 2

[Jason Laster [:jlast]]

I believe the rationale was that you might want to have multiple connections (i.e. the devtools panel and an editor connecting remotely). I believe that this was a feature that was added early on and has not been well tested/supported. I could be totally off the mark as well. CC Jim

Comment 3

[Jim Blandy :jimb]

The rationale for supporting multiple Debuggers at the SpiderMonkey level was that people might want to build multiple tools that interoperate. But the devtools server ideally would have only one Debugger per debuggee per connection, since we would like share Debugger.Foo objects freely between them.

Comment 4

[Jim Blandy :jimb]

Multiple Debugger support is thoroughly tested at the SpiderMonkey level. The server, I don't know.

Jason, I'm not sure what information you're looking for, but if this doesn't help, please clarify and flag me again.