Closed Bug 1536689 Opened 6 years ago Closed 6 years ago

Make nsTDependentString null-terminated string assertion fatal

Categories

(Core :: XPCOM, enhancement)

Product:
Core
Component:
XPCOM
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Bug 1536689 - Make AssertValidDependentString asserts more fatal. r=bholley,froydnj
47 bytes, text/x-phabricator-request
Details | Review

If it's security sensitive, it should not be an NS_ASSERTION.

We should catch these issues ASAP. This NS_ASSERTION also bit me in the past.

Attachment #9052155 - Attachment description: Bug 1536689 - Make AssertValidDependentString a diagnostic assert. r=bholley,froydnj → Bug 1536689 - Make AssertValidDependentString asserts more fatal. r=bholley,froydnj
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eeca0e099b8a Make AssertValidDependentString asserts more fatal. r=bholley

https://hg.mozilla.org/mozilla-central/rev/eeca0e099b8a

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
See Also: → 1545998
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: