1536707 - firefox freezes when changing user context colour

Status: RESOLVED DUPLICATE of bug 1517101

(Core :: Performance, defect)

Description

[ricardo ardissone [:rardiol]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

FF 65.0.1 on Linux mint 17.3
Create a new profile.
Change configs and install addons(I'm not sure if the bug manifested in another config setting too).
Open user context config, add a new config, change colour or icon of the new profile.

Actual results:

Firefox freezes for a few seconds to a minute. 100% CPU usage.

Reproducing the bug by changing colour again also freezes for a while. Safe mode doesn't fix it.
Profile: https://perfht.ml/2HuNA1d

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Unfortunately the profile doesn't have reasonable symbols, something is wrong there.

Could you perhaps provide a stack using Nightly? https://www.mozilla.org/en-US/firefox/channel/desktop/#nightly

Comment 2

[ricardo ardissone [:rardiol]]

Can't reproduce on Nightly 68.0a1 (2019-03-20) (64-bit).

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

What do you mean with
"Open user context config, add a new config, change colour or icon of the new profile."
Do you have exact steps to reproduce (perhaps even just FF65)

Comment 4

[Will Hawkins]

https://addons.mozilla.org/en-US/firefox/addon/multi-account-containers/

You need this extension to be able to follow his instructions. However, I was not able to reproduce this when I tried (albeit briefly).

Comment 5

[ricardo ardissone [:rardiol]]

I didn't install this extension. just edited privacy.userContext.enabled = true.

As for the steps:
Press alt.
Click on 'file' > New container tab > manage containers.
Click on preferences for any of the containers I already have.
Click on a colour.

Comment 6

[Vicky Chin [:vchin]]

Ricardo, are you able to reproduce this on FF65 and generate a new profile?

Comment 7

[ricardo ardissone [:rardiol]]

Yes, here is another, on a new FF profile: https://perfht.ml/2WoIsiF

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

That still doesn't have proper symbols.
Are you using a build from Mozilla or some some Linux distro?

Comment 9

[ricardo ardissone [:rardiol]]

One from my distro.

Here's a profile with a FF straight from mozilla.org: http://bit.ly/2HGK0kG. If that's not the one with symbols, could you please point me to where to download it?

Comment 10

[Markus Stange [:mstange]]

That profile has proper symbols. And it points out a problem with web components / custom elements.

Emilio, does the profile in comment 9 ring any bells?

The profile in comment 0 look like a very different issue - that profile seems to suffer from processing a large number of accessibility events, potentially in response to DOM changes from the Tree Tabs extension.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

That's the custom queryInterface / customInterface stuff that customElements have in chrome documents.

Seems like some chrome js code is just recursively calling there until the JS engine stops due to over-recursion.

I'm not particularly familiar with that code:

https://searchfox.org/mozilla-central/rev/444ee13e14fe30451651c0f62b3979c76766ada4/toolkit/content/customElements.js#496

Maybe Brian or Neil can help more?

Comment 12

[Brian Grinstead [:bgrins]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #11)

That's the custom queryInterface / customInterface stuff that customElements have in chrome documents.

Seems like some chrome js code is just recursively calling there until the JS engine stops due to over-recursion.

I'm not particularly familiar with that code:

https://searchfox.org/mozilla-central/rev/444ee13e14fe30451651c0f62b3979c76766ada4/toolkit/content/customElements.js#496

Maybe Brian or Neil can help more?

This looks a lot like Bug 1517101 (fixed in Firefox 66 by Bug 1492326). Would it be possible for you to test on 66 and confirm it's fixed there?

Comment 13

[Daniel Holbert [:dholbert]]

(In reply to Brian Grinstead [:bgrins] from comment #12)

This looks a lot like Bug 1517101 (fixed in Firefox 66 by Bug 1492326). Would it be possible for you to test on 66 and confirm it's fixed there?

For now, in the absence of a response, let's assume that this was correct. But if it turns out this is still an issue, feel free to reopen/un-dupe!