1536755 - Page remains zoomed in when switching from portrait to landscape mode on youtube.com

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Eliza Balazs]

Environment:
Devices:
Nexus 6P(Android 8.1.0);
Samsung Galaxy Tab S3 (Android 8);
Samsung Galaxy S8+ (Android 8.0.0).

Build: Nightly 68.0a1 (2019-03-19);

Steps to reproduce:

1. Go to youtube.com;
2. Switch to landscape mode;
3. Switch to portrait mode;
4. Observe the behavior.

Expected result:
The page switches back to portrait mode without being zoomed in.

Actual result:
After going back to portrait mode, the page is zoomed in.

Notes:

• Not reproducible on Nightly 67.0a1 (2019-03-12), Beta 66.0b13, Release 65.0.1;
• The page is stuck in this state until you refresh it;
• This is reproducible even if you select a video first and then switch to landscape mode;
• Video: https://drive.google.com/file/d/1YkKixNmE6Wo1F_lcQrM2wvdpOQae8lj2/view

Comment 1

[Eliza Balazs]

Update:
This is also reproducible on

• amazon.com;
• imdb.com;
• ebay.com;
• cnn.com.

Note:
On ebay.com and cnn.com the page can be zoomed out, but the page gets zoomed in each time you change the device orientation.
Video for this case: https://drive.google.com/file/d/1yZZCWhWdxNX92tRZLccssDYyQDeskzlg/view
Do you think its better to file a new bug for this second scenario?

Thanks!

Comment 2

[Eliza Balazs]

Hello!

I found a regression for this issue:

Last good revision: e0861be8d6c0fff8066fc5fe39e720dc55524122
First bad revision: 34e99cf78401ab40f6217e0b445e93aa86518d86

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e0861be8d6c0fff8066fc5fe39e720dc55524122&tochange=34e99cf78401ab40f6217e0b445e93aa86518d86

From the above pushlog this could be caused by https://bugzilla.mozilla.org/show_bug.cgi?id=1512838.

kats: Can you please have a look? Thank you!

Comment 3

[Levente Sacal]

Also happening on imdb.com on the latest Nightly 68.0a1 (2019-03-20) using OnePlus 3 (Android 6.0.1).

Comment 4

[Kartikaya Gupta (email:[e-mail])]

(In reply to Eliza Balazs from comment #2)

I found a regression for this issue:

Last good revision: e0861be8d6c0fff8066fc5fe39e720dc55524122
First bad revision: 34e99cf78401ab40f6217e0b445e93aa86518d86

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e0861be8d6c0fff8066fc5fe39e720dc55524122&tochange=34e99cf78401ab40f6217e0b445e93aa86518d86

I got a different regression range, which narrowed it down to bug 1501665. That seems like a much plausible culprit. Brad, can you take a look?

Comment 5

[Brad Werth [:bradwerth]]

This is most certainly due to the patches for Bug 1501665. I'll try to sort it out.

Comment 6

[Brad Werth [:bradwerth]]

Attachment: Bug 1536755 Part 1: Enforce viewport zoom constraints when the content size changes. r=botond!

Comment 7

[Brad Werth [:bradwerth]]

Attachment: Bug 1536755 Part 2: Add a test of meta viewport fixed width and zoom. r=botond!

Depends on D24424

Comment 8

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=753eec44f45ed54a70bd8e8c513a00f63859dd3e

Comment 9

[Eliza Balazs]

kats: Thank you for looking into this!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3065199857a
Part 1: Enforce viewport zoom constraints when the content size changes. r=botond
https://hg.mozilla.org/integration/autoland/rev/04fb1566c7c1
Part 2: Add a test of meta viewport fixed width and zoom. r=botond

Comment 11

[Botond Ballo [:botond]]

Attachment: Bug 1536755 - Fix eslint trailing-comma failures. r=apavel

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52e395fe423e
Fix eslint trailing-comma failures. r=apavel

Comment 13

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/d3065199857a
https://hg.mozilla.org/mozilla-central/rev/04fb1566c7c1
https://hg.mozilla.org/mozilla-central/rev/52e395fe423e

Comment 14

[Brad Werth [:bradwerth]]

(In reply to Botond Ballo [:botond] from comment #11)

Created attachment 9053185 [details]
Bug 1536755 - Fix eslint trailing-comma failures. r=apavel

Thank you for the cleanup.

Comment 15

[Eliza Balazs]

Hi!

I tested this on the latest version of Nightly 68.0a1 (2019-03-28) with Nexus 6P(Android 8.1.0), Samsung Galaxy Tab S3 (Android 8, Tablet) and the issue from the Description is fixed, but the issue from Comment 1 is still reproducible.

(In reply to Eliza Balazs from comment #1)

Note:
On ebay.com and cnn.com the page can be zoomed out, but the page gets zoomed in each time you change the device orientation.
Video for this case: https://drive.google.com/file/d/1yZZCWhWdxNX92tRZLccssDYyQDeskzlg/view
Do you think its better to file a new bug for this second scenario?

Brad: Can you please have a look? Thanks!

Comment 16

[Brad Werth [:bradwerth]]

(In reply to Eliza Balazs from comment #15)

Hi!

I tested this on the latest version of Nightly 68.0a1 (2019-03-28) with Nexus 6P(Android 8.1.0), Samsung Galaxy Tab S3 (Android 8, Tablet) and the issue from the Description is fixed, but the issue from Comment 1 is still reproducible.

Yes, there's still work to be done. Bug 1523844 is covering this issue.

Comment 17

[Eliza Balazs]

(In reply to Brad Werth [:bradwerth] from comment #16)

(In reply to Eliza Balazs from comment #15)

Hi!

I tested this on the latest version of Nightly 68.0a1 (2019-03-28) with Nexus 6P(Android 8.1.0), Samsung Galaxy Tab S3 (Android 8, Tablet) and the issue from the Description is fixed, but the issue from Comment 1 is still reproducible.

Yes, there's still work to be done. Bug 1523844 is covering this issue.

Since Bug 1523844 is covering the issue described in Comment 15, I'll mark this as Verified on Firefox 68.

Thank you!