1536757 - Prefs > Calendar > Views the "Day starts at" menupopup doesn't open

Status: RESOLVED FIXED

(Calendar :: Preferences, defect)

Description

[Richard Marti (:Paenglab)]

In prefs > Calendar > Views the "Day starts at" menupopup doesn't open. I see no errors in my console.

I can't say since when this happens.

Comment 1

[Richard Marti (:Paenglab)]

It seems that the this.value isn't resolved in https://searchfox.org/comm-central/rev/882e988fb21906ea2b7413351e4aa5a6049517d7/calendar/base/content/preferences/views.xul#117 and https://searchfox.org/comm-central/rev/882e988fb21906ea2b7413351e4aa5a6049517d7/calendar/base/content/preferences/views.xul#187.

When I set a fixed value in views.js the menu is shown. Maybe a fallout of the menulist de-xbl.

Geoff, do you know what change is needed?

Comment 2

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

Attachment: 1536757-calendar-view-prefs-1.diff

Does the trick. You weren't far off in your assessment.

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9052443 [details] [diff] [review]
1536757-calendar-view-prefs-1.diff

Thanks.

Comment 4

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/f50cb5efc43d6534668fe271c427d91927fe59bc

Comment 5

[Jorg K (CEST = GMT+2)]

TB 67 beta, Cal 6.9:
https://hg.mozilla.org/releases/comm-beta/rev/8a987f6e635068665ccbc5726d8c09ede587e70c
Regression from bug 1527770.