1536780 - generic-worker: Support contentEncoding artifact property in task payload

Status: RESOLVED FIXED

(Taskcluster :: Workers, enhancement)

Description

[Pete Moore [:pmoore][:pete]]

Generic worker already supports explicit setting of HTTP Content-Type header for task artifacts via optional task property payload.artifacts[*].contentType.

It should do the same for HTTP Content-Encoding header via optional task property payload.artifacts[*].contentEncoding.

This would allow a task author to explicitly set Content-Encoding to either identity or gzip.

I propose we support only these two values.

Existing behaviour to be preserved if property not supplied.

Comment 1

[Vaibhav Kaushik]

can I work on this bug?

Comment 2

[Pete Moore [:pmoore][:pete]]

Sure, Vaibhav.

Source code is available at https://github.com/taskcluster/generic-worker.

Let me know if you have questions.

Comment 3

[Pete Moore [:pmoore][:pete]]

Note, the link in comment 0 is no longer valid, but the payload schemas can be seen in raw here:

https://github.com/taskcluster/generic-worker/blob/v14.1.0/native_all-unix-style.yml#L107-L121 (mac, linux)
https://github.com/taskcluster/generic-worker/blob/v14.1.0/native_windows.yml#L111-L124 (windows)

Comment 4

[Pete Moore [:pmoore][:pete]]

Hi Vaibhav, are you still working on this?

Many thanks,
Pete

Comment 5

[Vaibhav Kaushik]

Yes Pete, I am back on track & working on it again

Comment 6

[Pete Moore [:pmoore][:pete]]

Thanks Vaibhav!

Comment 7

[Pete Moore [:pmoore][:pete]]

Attachment: GitHub Pull Request for generic-worker

Comment 8

[Pete Moore [:pmoore][:pete]]

https://github.com/taskcluster/generic-worker/commit/52812d990c857adc675b56fa15e5be0bccb9974f

Comment 9

[Pete Moore [:pmoore][:pete]]

Released in generic-worker 16.2.0.

Comment 10

[Pete Moore [:pmoore][:pete]]

Note: testing on gecko Windows worker types in this try push.

Comment 11

[Pete Moore [:pmoore][:pete]]

Attachment: GitHub Pull Request for OpenCloudConfig