1536857 - Map scopes for Logpoints

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P5)

Description

[:Harald Kirschner :digitarald]

Attachment: logpoint on Firefox send

What were you doing?

Add a logpoint to a source mapped file and reference a variable.

STR:

• Open Debugger on send.firefox.com
• Open dragManager.js and add a breakpoint in the default export
• Change the breakpoint into a logpoint with state as expression
• Refresh

What happened?

Error: state is not defined

The variable state isn't found, as it is mapped to variable t.

What should had happened?

state is correctly mapped and referenced.

Comment 1

[:Harald Kirschner :digitarald]

Attachment: breakpoint on Firefox Send

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Another test case (from dup bug):

1. Load http://janodvarko.cz/tests/bugzilla/1539142/
2. Open webpack/src/App.js
3. Create a logpoint with the following expression: sum (it's a function imported and available in the scope)
4. Click Click Me button on the page
5. Watch the Console panel: sum is not defined

Honza

Comment 4

[mattheww]

Attachment: Bug 1536857 - Map scopes for Logpoints

Comment 5

[mattheww]

Attachment: Bug 1536857 - Map scopes for Logpoints

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b4e497afd6b
Map scopes for Logpoints r=loganfsmyth

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5b4e497afd6b

Comment 8

[:Harald Kirschner :digitarald]

We should call out this feature in MDN to make it easier to find via https://phabricator.services.mozilla.com/D80280.

Comment 9

[Janet Swisher]

Added a note to Set a logpoint, pointing out that logpoints can be used with source-mapped code.