Status

enhancement
P1
normal
RESOLVED FIXED
4 months ago
23 days ago

People

(Reporter: ochameau, Assigned: ochameau)

Tracking

Details

Attachments

(1 attachment)

Bug 1524688 introduced a new way to register the XPCOM implemented in JS statically. This reduces the overhead of it.
Ideally we should convert to this method but unfortunately, it breaks artifact builds support. This static definition requires a full build of Firefox.

So I'll make that work depend on bug 1533831 which will enable the remote agent by default and make it so that the static registration of remote agent jsm is part of artifact builds.

Depends on: 1536888

A new way to register JS XPCOM has been introduced in bug 1524688.
Convert Remote agent to this new registration.

I submitted the patch for review here, but this is only meant to be landed after bug 1533831 is landed.
This should help justify why I'm converting RemoteAgent to be a JSM in bug 1536888.

(In reply to Alexandre Poirot [:ochameau] from comment #0)

Bug 1524688 introduced a new way to register the XPCOM implemented
in JS statically.

I wish these sort of changes were announced more publicly. It’s
quite hard to keep track of.

Ideally we should convert to this method but unfortunately, it
breaks artifact builds support. This static definition requires
a full build of Firefox.

I always use a full build locally, so I’m not too worried about it.

(In reply to Alexandre Poirot [:ochameau] from comment #2)

I submitted the patch for review here, but this is only meant to
be landed after bug 1533831 is landed. This should help justify
why I'm converting RemoteAgent to be a JSM in bug 1536888.

Yes, thanks! That puzzled me to begin with.

Status: NEW → ASSIGNED
Priority: -- → P1

(In reply to Andreas Tolfsen ⦗:ato⦘ from comment #3)

Ideally we should convert to this method but unfortunately, it
breaks artifact builds support. This static definition requires
a full build of Firefox.

I always use a full build locally, so I’m not too worried about it.

I do use artifact and having to do full builds ruins my productivity here,
so I'll wait before landing this one.

Is it there a tracking bug for making it work with artifact builds?
If so, we should mark it to block this one.

Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d891eef5e1f4
Register RemoteAgent JS XPCOM by using new registration method. r=ato
Status: ASSIGNED → RESOLVED
Closed: 23 days ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.