Closed Bug 1537542 Opened 1 year ago Closed 1 year ago

Options page / Options button should not be displayed for add-ons not allowed in Private Browsing mode

Categories

(WebExtensions :: Frontend, defect, P1)

67 Branch
defect

Tracking

(firefox67 verified, firefox68 verified)

VERIFIED FIXED
mozilla68
Tracking Status
firefox67 --- verified
firefox68 --- verified

People

(Reporter: juraj.masiar, Assigned: rpl)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

See the video.

  1. Using FF 67, open Private Browsing window
  2. open about:addons
  3. click Options button for any of your add-ons that is not allowed in Private Browsing

Actual results:

None of the Options page would work while the add-on is not allowed in Private Browsing.

Expected results:

The "Options" button or the inline Options in the detail should not be available unless addon is allowed in Private Browsing mode.

I think this needs to get in and uplifted.

Priority: -- → P1

STR

  • install "Duplicate Tabs Closer"
  • open private window
  • go to about:addons, choose extensions
  • is preferences button on the add in the list?
  • enter details for addon
  • look for preferences button bottom left

Expected:

not present in either case

Actual:

present, and opening causes an unusable preferences tab for the addon

Assignee: nobody → lgreco
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/6e7b485a2f31
Hide addon preferences if the addon cannot access the current window. r=aswan
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Comment on attachment 9052926 [details]
Bug 1537542 - Hide addon preferences if the addon cannot access the current window. r?aswan!,mixedpuppy

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1380809
  • User impact if declined: Potential failures when opening about:addons in private windows.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: STR in comment 2
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): covered by tests, minimal changes in about:addons.
  • String changes made/needed: none
Attachment #9052926 - Flags: approval-mozilla-beta?
Flags: qe-verify?
Attached image Bug1537542.gif

This issue is verified as fixed on Firefox 68.0a1 (20190327175114) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached video.

Status: RESOLVED → VERIFIED
Flags: qe-verify?

Comment on attachment 9052926 [details]
Bug 1537542 - Hide addon preferences if the addon cannot access the current window. r?aswan!,mixedpuppy

P1 for a new 67 feature, verified by QA on nightly, patch with tests, uplift approved for 67 beta 6, thanks.

Attachment #9052926 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/projects/ash/rev/6e7b485a2f314633b7f059095207ad3655d83759
Bug 1537542 - Hide addon preferences if the addon cannot access the current window. r=aswan
Attached image Bug1537542-Beta.gif

This issue is verified as fixed on Firefox 67.0b6 (20190328152334) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached video.

Version: Firefox 67 → 67 Branch
You need to log in before you can comment on or make changes to this bug.