153757 - hasAttribute on a HTML label crashes

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Robert Ginda]

#0  0x41ba7e3c in nsHTMLLabelElement::HasAttribute (this=0x8b00d98, 
    aName=@0x8b46110, aReturn=0xbfffaab0) at nsHTMLLabelElement.cpp:156
155       NS_IMETHOD HasAttribute(const nsAString& aName, PRBool* aReturn) {
156         return HasAttribute(aName, aReturn);
157       }

When called, this method recurses on itself until it blows the stack.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: Patch

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 88868 [details] [diff] [review]
Patch

r=caillon

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 88868 [details] [diff] [review]
Patch

Duh!

sr=jst

Comment 4

[Peter Van der Beken [:peterv]]

Checked in.

Comment 5

[Blake Ross]

maybe this obvious fix should go on the branch?

Comment 6

[Johnny Stenback (:jst)]

Nominating, this is a trivial fix for a guaranteed unconditional crash, there's
no reason to not take this fix AFAICT.

Comment 7

[scottputterman]

adding adt1.0.1+.  Please get drivers approval before checking into the branch.

Comment 8

[Johnny Stenback (:jst)]

drivers approval request sent.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 88868 [details] [diff] [review]
Patch

Please land this on the 1.0.1 branch.  Once there, replace the
"mozilla1.0.1+" keyword with the "fixed1.0.1" keyword.

Comment 10

[Sivakiran Tummala]

verified on win32 and linux branch