Cleanup generic font-family handling.

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P3
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(2 attachments)

It was itching since I fixed bug 1536718, so I cleaned it up a bit.

No longer blocks: 1536718
Depends on: 1536718

To be more similar between Rust and C++. This introduces GenericFontFamily and
exposes that plus FontFamilyNameSyntax to C++, using that where appropriate
instead of plain uint8_t as we were doing.

As a follow-up, as discussed on IRC with Jonathan, we can remove the -moz-fixed
family, and turn it just into an alias of Monospace.

The only non-trivial change is the MatchType changes, but they're ok I think.
The code already assumed at most one CSS generic, and the struct still takes 8
bits. I've verified that the relevant tests are passing (though try is closed).

Depends on D24271

Blocks: 1537594
Priority: -- → P3
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c7565f50239a
Trivially cleanup and remove some dead font code. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/0cd1411e2fb3
Cleanup generic font-family handling. r=jfkthame
Attachment #9052422 - Attachment description: Bug 1537575 - Trivially cleanup and remove some dead font code. r=heycam,jfkthame → Bug 1537575 - Trivially cleanup and remove some dead font code. r=jwatt
Attachment #9052423 - Attachment description: Bug 1537575 - Cleanup generic font-family handling. r=heycam,jfkthame → Bug 1537575 - Cleanup generic font-family handling. r=jfkthame

Should be fixed when it relands, thanks.

Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/429346732b02
Trivially cleanup and remove some dead font code. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/15c4170c3192
Cleanup generic font-family handling. r=jfkthame
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.