1537575 - Cleanup generic font-family handling.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

It was itching since I fixed bug 1536718, so I cleaned it up a bit.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1537575 - Trivially cleanup and remove some dead font code. r=jwatt

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1537575 - Cleanup generic font-family handling. r=jfkthame

To be more similar between Rust and C++. This introduces GenericFontFamily and
exposes that plus FontFamilyNameSyntax to C++, using that where appropriate
instead of plain uint8_t as we were doing.

As a follow-up, as discussed on IRC with Jonathan, we can remove the -moz-fixed
family, and turn it just into an alias of Monospace.

The only non-trivial change is the MatchType changes, but they're ok I think.
The code already assumed at most one CSS generic, and the struct still takes 8
bits. I've verified that the relevant tests are passing (though try is closed).

Depends on D24271

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7565f50239a
Trivially cleanup and remove some dead font code. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/0cd1411e2fb3
Cleanup generic font-family handling. r=jfkthame

Comment 4

[Arthur Iakab [arthur_iakab]]

Backed out 3 changesets (bug 1537594, bug 1537575) for causing build bustages on mathml/nsMathMLChar.cpp CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/8d2f695cecaf1cbbaa38623569e55357ab8cd5a9

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=237409659&revision=7375a830b5ef05e6d3049aed28b979f591a3dd12&searchStr=toolchains

Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=237409659&repo=autoland

Emilio could you please take a look?

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Should be fixed when it relands, thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/429346732b02
Trivially cleanup and remove some dead font code. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/15c4170c3192
Cleanup generic font-family handling. r=jfkthame

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/429346732b02
https://hg.mozilla.org/mozilla-central/rev/15c4170c3192