Closed Bug 1537584 Opened 7 years ago Closed 6 years ago

[wpt-sync] Sync PR 15945 - Create RTCIceTransport using a webrtc::IceTransportInterface object.

Categories

(Core :: WebRTC, enhancement, P4)

Product:
Core
Component:
WebRTC
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15945 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15945
Details from upstream follow.

Marina Ciocea <marinaciocea@chromium.org> wrote:

Create RTCIceTransport using a webrtc::IceTransportInterface object.

Previously, when creating a blink::RTCIceTransport, the corresponding
webrtc::IceTransportInterface object was created by the
IceTransportAdapterImpl. However, in DTLS transport implementation, the
webrtc object is preexisting. Pass the preexisting webrtc object when creating
the blink::RTCIceTransport object in this case.

Bug: 907849
Change-Id: Ia024afc101be830e30f233d6ef1bf39f141227df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520486
Commit-Queue: Marina Ciocea \<marinaciocea@chromium.org>
Reviewed-by: Harald Alvestrand \<hta@chromium.org>
Reviewed-by: Henrik Boström \<hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642487}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → WebRTC
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/da54f6464b80 [wpt PR 15945] - Create RTCIceTransport using a webrtc::IceTransportInterface object., a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/0b8adfc834de [wpt PR 15945] - Create RTCIceTransport using a webrtc::IceTransportInterface object., a=testonly

https://hg.mozilla.org/mozilla-central/rev/da54f6464b80
https://hg.mozilla.org/mozilla-central/rev/0b8adfc834de

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.