1537657 - Paused workers stay as zombies on page refresh

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[:Harald Kirschner :digitarald]

Attachment: image.png

What were you doing?

1. Open Debugger on https://tuner.cloud/
2. Open the worker file webpack:///pitchfinder-worker.js and set a breakpoint in the message handler
3. Wait for the breakpoint to be hit (sing a song or tune your guitar)
4. Refresh

What happened?

Worker list expands on each refresh.

(Bonus: Breakpoints panel stays empty as well, while reason shows Paused on Breakpoint)

What should have happened?

Only latest worker gets shown, list gets cleared on page refresh.

---

Original source: https://github.com/digitarald/chromatic-tuner-web-app

Comment 1

[:Harald Kirschner :digitarald]

Attachment: Annotated recording

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I am able to reproduce it. Also note that line BP marker is missing in the BP gutter after refresh. It's visible in the recording, but not explicitly mentioned here.

Honza

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

When trying this test case I've also noticed bug 1537748

Honza

Comment 4

[Logan Smyth [:loganfsmyth]]

Brian, do you have thoughts on this?

Comment 5

[Logan Smyth [:loganfsmyth]]

Are we just failing to resume the workers so they never get detached/destroyed?

Comment 6

[Brian Hackett [Laid off!]]

Paused workers are not resumed when navigating, but I don't think that just telling them to resume is the right fix: they could pause at a breakpoint somewhere else (or an unpaused worker could pause at a breakpoint before it is destroyed) and will not finish shutting down.

The patch I'm about to post takes care of this by detaching from all worker threads when navigating. This unpauses the worker threads and should prevent them from pausing anywhere else, and keeps the threads from piling up when refreshing.

Comment 7

[Brian Hackett [Laid off!]]

Attachment: Bug 1537657 - Detach from workers when navigating, r=loganfsmyth.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75634ae8f7c5
Detach from workers when navigating, r=loganfsmyth.

Comment 9

[Arthur Iakab [arthur_iakab]]

Backed out changeset 75634ae8f7c5 (bug 1537657) for causing debugger failures CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/ed5dca04ca54811c2208c708b3c02e9d2cb10f4e

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=75634ae8f7c53f39474e2dc40a247006254945bc&searchStr=linux%2Cx64%2Copt%2Cnode%2Ctests%2Csource-test-node-debugger-tests%2Cnode%28debugger%29

Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=235583688&repo=autoland

Brian could you pleas take a look?

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/69a4cc3f97e8
Detach from workers when navigating, r=loganfsmyth.

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/69a4cc3f97e8

Comment 12

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/projects/ash/rev/69a4cc3f97e8252069ac6bf6655757b6edfecea6
Bug 1537657 - Detach from workers when navigating, r=loganfsmyth.