153767 - After a plug-in error, following page load will not enable view source

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Olivier Cahagne]

Build ID: 2002062304 (trunk), Win2k.

Have been seeing this consistently (not a regression AFAIK) since Mozilla 0.8.

Steps to reproduce bug:
1. Load http://www.epita.fr/~cahagn_o/mozbug/test.pdf (make sure you have the
Acrobat plug-in, I use v.4 because Acrobat 4 is overloading the Acrobat Reader
v.5), 
2. This will generate an error because test.pdf is a dummy file (contains
34534), this error is needed for next step,
3. Load on the same window (using URL bar):
http://www.epita.fr/~cahagn_o/mozbug/bug.html
4. Richt click on page and view source, you can also use menu View -> Page
Source or Ctrl-U,
5. It doesn't work, cannot view source, plus the context menu mentions a frame
whereas there's no frame on this page.

I've been seeing this with other plug-ins (WMP) and it's even worse when the
next page you try to load has some CSS because it won't load the CSS rendering
the page ugly. Fix for bug 133286 didn't solve this, copying the people for this
patch just in case it can be related.

Comment 1

[av (gone)]

Peter, looks like we are not updating document structure after failure on
full-page plugins. This is probably related to about:plugins not working after
full-page plugins.

Comment 2

[Peter Lubczynski]

What NPAPI function returns error?

Comment 3

[rubydoo123]

av

Comment 4

[serge (gone)]

well, unfortunately we cannot programmatically detect this error state of
plugins, NPAPI simply does no have such func:(
from mozilla point of view every thing is fine it serves whole stream to the
plugin, and has no idea that plugin chokes on that data.

Comment 5

[Peter Lubczynski]

Perhaps bug 90256 may help with its synthetic document for full-page plugins?

Comment 6

[rubydoo123]

The plug-ins triage team (av, beppe, peterl, serge and shrir) have reviewed this
issue and have made the following determination:

This is functional on the trunk, but not on the branch. This is likely a result
of the fix from 146143.

Shrir will verify the fix on the branch when 146143 is checked in.

Comment 7

[Olivier Cahagne]

using build 2002071008 on Win2k (trunk), I confirm fix for bug 146143 is
excellent: I'm not experiencing issues anymore with this particular testcase and
the pages with CSS where I had some errors previously after having loaded PDF or
WMP.

Comment 8

[av (gone)]

Marking Fixed based on the reporter's comments.

Comment 9

[shrirang khanzode]

.