flag NS_STATE_IS_OUTER_SVG is redundant
Categories
(Core :: SVG, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: violet.bugreport, Assigned: violet.bugreport)
Details
Attachments
(1 file)
The frame state bit NS_STATE_IS_OUTER_SVG is redundant: Setting this bit is exactly equal to being an nsSVGOuterSVGFrame, checking the bit can be done by nsIFrame::IsSVGOuterSVGFrame() https://dxr.mozilla.org/mozilla-central/source/layout/generic/nsIFrame.h#2804. There is little (if any) performance difference.
This bit is arguably harmful, because it is a shared bit at 20 conflicting with aother irrelevant bit (NS_BLOCK_NEEDS_BIDI_RESOLUTION) due to lack of bits. Without heeding this, one may write code with hidden bugs.
There aren't many places using this bit, we can easily clean them up.
Some context: https://bugzilla.mozilla.org/show_bug.cgi?id=1504072#c6
|
Assignee | |
Comment 1•6 years ago
|
||
NS_STATE_IS_OUTER_SVG is redundant, we clean it up and use
nsIFrame::IsSVGOuterSVGFrame() instead.
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Updated•6 years ago
|
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a948e5e83e6
Clean up NS_STATE_IS_OUTER_SVG flag in favor of IsSVGOuterSVGFrame r=longsonr
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Description
•