Closed Bug 1537712 Opened 5 years ago Closed 2 years ago

JSON Viewer does not check key modifiers

Categories

(DevTools :: JSON Viewer, defect, P3)

65 Branch
defect

Tracking

(firefox108 fixed)

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: yurivkhan, Assigned: zacnomore)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

  1. Navigate to a JSON document.
  2. Press Alt+←.

Actual results:

Highlight moves to parent node, or node is collapsed.

Expected results:

Should navigate back through history.

Cause: TreeView.js#onKeyDown neglects to check the event object for modifier keys.

This breaks history navigation (Alt+←/→), Alt+Home, and might affect extensions.

Has STR: --- → yes

Thanks for the report!

I can reproduce it on my machine.

Honza

Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Severity: normal → S3
Assignee: nobody → cczac1
Status: NEW → ASSIGNED
Attachment #9300018 - Attachment description: Bug 1537712 - Listen for key modifiers in json view hotkeys r?honza → Bug 1537712 - Listen for key modifiers in json view hotkeys r?jdescottes
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/820bf48074ce
Listen for key modifiers in json view hotkeys r=jdescottes
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: