1537723 - LWT-static theme migration not working on Fennec

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Add-on Manager, defect, P1)

Description

[Alexandra Moga [:LexaSV]]

User Agent: Mozilla/5.0 (Android 8.0.0; Mobile; rv:68.0) Gecko/68.0 Firefox/68.0

[Prerequisites]:

• xpinstall.signatures.dev-root = true
• xpinstall.signatures.required = false

Not sure if the following prefs have an impact, since they are handling webextension updates, but I've configured them anyway:

• extensions.update.url - versioncheck points to -dev
• extensions.update.background.url - versioncheck points to -dev
• extensions.update.interval - 1
• extensions.autoupdate.interval - 1

[STR]:

1. Install a LWT on AMO -dev
   • I have the following example set in lightweightThemes.usedThemes:

[{"id":"60179","name":"little flowers","headerURL":"https://addons-dev-cdn.allizom.org/user-media/addons/60179/dupa.jpg?modified=1353156254","iconURL":"https://addons-dev-cdn.allizom.org/user-media/addons/60179/preview_small.jpg?modified=1353156254","previewURL":"https://addons-dev-cdn.allizom.org/user-media/addons/60179/preview_large.jpg?modified=1353156254","author":"bluszcz","updateURL":"https://versioncheck-dev.allizom.org/en-US/themes/update-check/60179","version":"1.0"}]

2. Restart your browser
3. Go to about:addons and check if the migrated version of the installed LWT is available

[Actual result]:

• the LWT theme hasn't been updated

[Expected result]:

• the migrated version should be available, i.e. the following static theme:
  https://addons-dev.allizom.org/en-US/firefox/addon/little-flowers/

[Notes]:

• Github reference: https://github.com/mozilla/addons-server/issues/9941

Comment 1

[Andrew Swan [:aswan]]

It looks like we're bailing out here:
https://searchfox.org/mozilla-central/rev/a7315d78417179b151fef6108f2bce14786ba64d/toolkit/mozapps/extensions/LightweightThemeManager.jsm#369-370

Since the preference lightweightThemes.update.enabled is not set on fennec

Comment 2

[Andrew Swan [:aswan]]

I'm having trouble with my local emulator setup. Can we get some help from QA: try setting the preference lightweightThemes.updated.enabled manually from about:config and then repeating the test?

If that works (and I expect it might) then that's a pretty simple fix that we should uplift right away.
If that doesn't work, gathering device logs with "adb logcat" and attaching them here would be helpful.

Comment 3

[Andrew Swan [:aswan]]

Attachment: Bug 1537723 Enable LWT updates on Android

Also ensure that LightweightThemeManager.updateOneTheme() returns
even if the update request fails.

Comment 4

[Alexandra Moga [:LexaSV]]

Setting the preference lightweightThemes.update.enabled in about config did the trick. I can confirm that updates are working with Android 8.0, on latest Nightly, Beta 67.0b5 and Firefox release.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1e03f3bba1a
Enable LWT updates on Android r=mixedpuppy

Comment 6

[Andrew Swan [:aswan]]

Comment on attachment 9053750 [details]
Bug 1537723 Enable LWT updates on Android

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: not a regression
• User impact if declined: Fennec users of lightweight themes will not be updated to the new theme format, and they will lose their themes in Firefox 68 due to bug 1525762
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Theme updates happened uneventfully on desktop last week. This patch just flips a pref to cause the same thing to happen on Fennec.
• String changes made/needed: none

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/d1e03f3bba1a

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

We have STR so let's have QA check with the next nightly that this is fixed and we can then uplift for the next Fennec beta (beta 7). Thanks.

Comment 9

[Sorina Florean [:sflorean]]

Ni on Stefan to verify this on latest Nightly.

Comment 10

[Stefan Deiac]

Hi, I tested this issue on the latest version of Nightly 68.0a1 (2019-03-29) following the steps from comment 0 and I wasn't able de reproduce the problem.

Device:

• Samsung Galaxy Tab S3 (Android 8.0);

Alexandra, can you double check to be sure that the issue it's fixed?
Thanks.

Comment 11

[Alexandra Moga [:LexaSV]]

Verified fixed on Nightly 68.0a1 Build ID 20190329094433 with Android 8.0. lightweightThemes.update.enabled pref is enabled by default and LWT update checks are running.

Comment 12

[Stefan Deiac]

Due to comment 11 and my findings, I'll make this issue as verified, thanks.

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9053750 [details]
Bug 1537723 Enable LWT updates on Android

Low risk patch, verified by QA on Nightly, approved for 67 beta 7, thanks.

Comment 14

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0f768a9686b1

Comment 15

[Levente Sacal]

Verified as fixed on Beta 67.0b7 build with Android 6.0.1.