1537728 - Simplify shouldCheck variable declaration in BrowserGlue._checkForDefaultBrowser

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P3)

Description

[Dão Gottwald [:dao]]

This:

let shouldCheck = AppConstants.DEBUG ? false :
                                       ShellService.shouldCheckDefaultBrowser;

(https://searchfox.org/mozilla-central/rev/7c20ad925005fbad7b8e08813115f1ec7fa1c248/browser/components/BrowserGlue.jsm#2598-2599)

... can be simplified to:

let shouldCheck = !AppConstants.DEBUG && ShellService.shouldCheckDefaultBrowser;

Comment 1

[Asra Q [:aqadri]]

Hi Dão, Can I please work on this?

Comment 2

[Dão Gottwald [:dao]]

(In reply to Syeda Asra Arshia Qadri [:aqadri] from comment #1)

Hi Dão, Can I please work on this?

Go ahead.

Comment 3

[Asra Q [:aqadri]]

Attachment: Bug 1537728: Simplify shouldCheck variable declaration in BrowserGlue._checkForDefaultBrowser r=dao

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2a2a47d7448c