Closed
Bug 1538099
Opened 5 years ago
Closed 5 years ago
Cranelift: adjust offset names in shared data structures
Categories
(Core :: JavaScript: WebAssembly, enhancement)
Core
JavaScript: WebAssembly
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: bbouvier, Assigned: bbouvier)
References
Details
Attachments
(2 files)
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
- Uses constants for function namespaces;
- Puts the source location retrieval under a single function;
|
|
Assignee | |
Comment 2•5 years ago
|
||
This renames:
- offset to codeOffset (which is an offset in the code generated by Cranelift,
relative to the beginning of the function, which we can now infer from the
name). - srcLoc to moduleBytecodeOffset, since this is what it is (and much clearer
than the previous name).
Pushed by bbouvier@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/34175a1386a8 Refactor baldrdash compile a bit; r=yury https://hg.mozilla.org/integration/mozilla-inbound/rev/14de4e6ce362 Rename CraneliftMetadata fields to help distinguish them; r=yury
|
||
Updated•5 years ago
|
Attachment #9052802 -
Attachment description: Bug 1538099: Refactor baldrdash compile a bit; r?yury → Bug 1538099: Refactor baldrdash compile a bit; r=yury
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/34175a1386a8
https://hg.mozilla.org/mozilla-central/rev/14de4e6ce362
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•