1538099 - Cranelift: adjust offset names in shared data structures

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement)

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1538099: Refactor baldrdash compile a bit; r=yury

• Uses constants for function namespaces;
• Puts the source location retrieval under a single function;

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1538099: Rename CraneliftMetadata fields to help distinguish them; r?yury

This renames:

• offset to codeOffset (which is an offset in the code generated by Cranelift,
  relative to the beginning of the function, which we can now infer from the
  name).
• srcLoc to moduleBytecodeOffset, since this is what it is (and much clearer
  than the previous name).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/34175a1386a8
Refactor baldrdash compile a bit; r=yury
https://hg.mozilla.org/integration/mozilla-inbound/rev/14de4e6ce362
Rename CraneliftMetadata fields to help distinguish them; r=yury

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/34175a1386a8
https://hg.mozilla.org/mozilla-central/rev/14de4e6ce362