Closed Bug 153816 Opened 24 years ago Closed 24 years ago

Translate nsIAccessible roles to ATK roles

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: john.sun, Assigned: john.sun)

References

Details

Attachments

(1 file, 2 obsolete files)

V3
12.90 KB, patch
aaronlev
: review+
jst
: superreview+
asa
: approval+
Details | Diff | Splinter Review
QA Contact: jrgm → mindy.liu
Blocks: 145863
Status: NEW → ASSIGNED
Aaronl, seek your review. Bill, Could you take a look at the code? Pls give me some suggestion.Especially if some vital/important ATK roles missed.
I would like to see this implemented with #ifdef to reduce the code footprint.
timeless doesn't like to add a new switch. we may use ACCESSIBILITY and XP_UNIX combined.
Timeless asked that you use MOZ_ as a prefix to our macros. So please go ahead with MOZ_ACCESSIBILITY_ATK.
ok, I'll add macro MOZ_ACCESSIBILITY_ATK (http://bugzilla.mozilla.org/show_bug.cgi?id=151388), and then submit another patch for this.
Attached patch V2 (obsolete) — — Splinter Review
According to aaron's suggestion. MOZ_ACCESSIBILITY_ATK will be effective soon. see http://bugzilla.mozilla.org/show_bug.cgi?id=151388 seek r=
Attachment #88914 - Attachment is obsolete: true
Comment on attachment 89521 [details] [diff] [review] V2 r=aaronl Thank you for all the useful comments!
Attachment #89521 - Flags: review+
Johnny, Could you pls sr this patch? Thanks. The patch just define the nsIAccessible roles with the suitable ATK roles when accessibility implementation based on ATK.
Attached patch V3 — — Splinter Review
Aaron, Could you pls review the new patch? Because the old V2 patches add "#include atk/atk.h", add the dependence to atk. I think it'd better remove the dependence, use the integer, equal to corresponding enumerate from ATK, to define nsIAccessible roles when MOZ_ACCESSIBLITY_ATK defined.
Attachment #89521 - Attachment is obsolete: true
Comment on attachment 90193 [details] [diff] [review] V3 r=aaronl
Attachment #90193 - Flags: review+
Attachment #90193 - Flags: superreview+
Comment on attachment 90193 [details] [diff] [review] V3 a=asa (on behalf of drivers) for checkin to 1.1
Attachment #90193 - Flags: approval+
checked in trunk
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: