153816 - Translate nsIAccessible roles to ATK roles

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[John Sun]

Comment 1

[John Sun]

Attachment: Translate nsIAccessible roles to ATK roles

Aaronl,
seek your review.

Bill,
Could you take a look at the code? Pls give me some suggestion.Especially if
some vital/important ATK roles missed.

Comment 2

[Aaron Leventhal]

I would like to see this implemented with #ifdef to reduce the code footprint.

Comment 3

[Kyle Yuan]

timeless doesn't like to add a new switch. we may use ACCESSIBILITY and XP_UNIX 
combined.

Comment 4

[Aaron Leventhal]

Timeless asked that you use MOZ_ as a prefix to our macros.
So please go ahead with MOZ_ACCESSIBILITY_ATK.

Comment 5

[John Sun]

ok, I'll add macro MOZ_ACCESSIBILITY_ATK
(http://bugzilla.mozilla.org/show_bug.cgi?id=151388), and then 
submit another patch for this.

Comment 6

[John Sun]

Attachment: V2

According to aaron's suggestion.

MOZ_ACCESSIBILITY_ATK will be effective soon. see
http://bugzilla.mozilla.org/show_bug.cgi?id=151388

seek r=

Comment 7

[Aaron Leventhal]

Comment on attachment 89521 [details] [diff] [review]
V2

r=aaronl

Thank you for all the useful comments!

Comment 8

[John Sun]

Johnny,
Could you pls sr this patch? Thanks.

The patch just define the nsIAccessible roles with the suitable ATK roles when
accessibility implementation based on ATK.

Comment 9

[John Sun]

Attachment: V3

Aaron,
Could you pls review the new patch?

Because the old V2 patches add "#include atk/atk.h", add the dependence to atk.

I think it'd better remove the dependence, use the integer, equal to
corresponding enumerate from ATK, to define nsIAccessible roles when
MOZ_ACCESSIBLITY_ATK defined.

Comment 10

[Aaron Leventhal]

Comment on attachment 90193 [details] [diff] [review]
V3

r=aaronl

Comment 11

[Johnny Stenback (:jst)]

Comment on attachment 90193 [details] [diff] [review]
V3

sr=jst

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 90193 [details] [diff] [review]
V3

a=asa (on behalf of drivers) for checkin to 1.1

Comment 13

[Pete Zha]

checked in trunk