1538189 - 4.18 - 22.84% build times (windows2012-32, windows2012-64, windows2012-aarch64) regression on push 70ce7207292ea5426224e7ccdb9503de9a726338 (Wed Mar 20 2019)

Status: VERIFIED FIXED

(Firefox Build System :: Toolchains, defect)

Description

[Ionuț Goldan [:igoldan]]

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=70ce7207292ea5426224e7ccdb9503de9a726338

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

23% build times windows2012-aarch64 opt aarch64 taskcluster-c4.4xlarge 3,506.59 -> 4,307.53
14% build times windows2012-aarch64 opt aarch64 taskcluster-c5.4xlarge 2,984.14 -> 3,411.72
6% build times windows2012-64 pgo taskcluster-c5.4xlarge 4,704.00 -> 4,963.14
5% build times windows2012-64 debug plain taskcluster-c5.4xlarge 1,784.11 -> 1,877.77
5% build times windows2012-64 pgo taskcluster-c4.4xlarge 5,977.53 -> 6,254.34
4% build times windows2012-32 pgo taskcluster-c4.4xlarge 6,069.88 -> 6,323.54

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=20008

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Comment 1

[(Away)]

Please back it out.

Comment 2

[Ionuț Goldan [:igoldan]]

(In reply to David Major [:dmajor] from comment #1)

Please back it out.

Ok, I've asked a Code sheriff to do this.

Comment 3

[Ionuț Goldan [:igoldan]]

So this got backed out here.

Comment 4

[Ionuț Goldan [:igoldan]]

I'm closing this as fixed, because we backed the regression out.

Comment 5

[Ionuț Goldan [:igoldan]]

Will reopen if the issue persist after re landing.