Closed Bug 1538232 Opened 9 months ago Closed 9 months ago

Intermittent GECKO(1801) | Assertion failure: !iter->IsNull(), at /builds/worker/workspace/build/src/dom/media/encoder/TrackEncoder.cpp:618

Categories

(Core :: Audio/Video: Recording, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- unaffected
firefox68 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: pehrsons)

References

Details

(Keywords: assertion, intermittent-failure, regression)

Attachments

(2 files)

Assignee: nobody → apehrson
Status: NEW → ASSIGNED

This looks like we're not handling a case of [1] properly.

[1] https://hg.mozilla.org/try/rev/bd43b92497c6c8a1007c75823e5b1333910c334a

With bug 1423253 we need to handle resetting future frames directly, and that
bug made the signaling of when to reset a bit more explicit, so a null image
is sent when a MediaDecoder is paused, so we don't render frames that were
already buffered, but after the pause took effect. And an image where the
time stamp is earlier than the previous frame's is sent when a MediaDecoder
seeks, as it intends to discard any previously buffered frames and render
only the new ones.

Note that this hackish way of signaling a MediaDecoder's intention comes from
the fact that we have only an append-based API for pushing frames through a
track, but the MediaDecoder's behavior is tightly coupled to the ImageContainer
API of sending frames to the compositor; SetCurrentFrames.

We will be iterating towards a SetCurrentFrames-like API for video tracks in the
future, to have a cleaner solution to this problem.

Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2278142d75e8
Add gtests for TestVideoTrackEncoder handling MediaDecoder seek and pause. r=bryce
https://hg.mozilla.org/integration/autoland/rev/bc5d94b22615
Handle MediaDecoder seeks and pauses in VideoTrackEncoder. r=bryce
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.