1538455 - Crash in [@ dav1d_lpf_h_sb_y_avx2]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Pascal Chevrel (relman team) -> :pascalc]

This bug is for crash report bp-77fe39ec-df4a-42db-b29c-d664d0190318.

Top 2 frames of crashing thread:

0 xul.dll dav1d_lpf_h_sb_y_avx2 
1 xul.dll static int decode_b third_party/dav1d/src/decode.c:1907

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I'm assigning it since it's marked critical.

Comment 2

[Alex Chronopoulos [:achronop]]

Win x64 is the only platform left at 32 bytes stack alignment. Given that we use clang it must be affected by LTO issue.

Comment 3

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1538455 - Use the default stack alignment in windows x64 for libdav1d. r?TD-Linux

Comment 4

[Alex Chronopoulos [:achronop]]

This was also the reason that Bug 1538474 has been backed out. I push it through this bug because it's the right place to be. When this is landed I will re-push Bug 1538474.

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=38ec54ccb9ff8dcf0a150fee77fdad8766502119

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d316af005a94
Use the default stack alignment in windows x64 for libdav1d. r=TD-Linux

Comment 6

[Nils Ohlmeier [:drno]]

Alex, how can we have a crash report for 67 Beta with dav1d if bug 1538474 prevents usage of dav1d?

Comment 7

[Alex Chronopoulos [:achronop]]

Good question, those reports must be from users who changed the pref by themselves to enable dav1d and disable RDD.

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/d316af005a94

Comment 9

[Alex Chronopoulos [:achronop]]

Comment on attachment 9054001 [details]
Bug 1538455 - Use the default stack alignment in windows x64 for libdav1d. r?TD-Linux

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1533742
• User impact if declined: Crash on windows x86_64 with dav1d. Without it we cannot enable dav1d on beta.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1537725
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix has been verified in Nightly do some time now.
• String changes made/needed:

Comment 10

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9054001 [details]
Bug 1538455 - Use the default stack alignment in windows x64 for libdav1d. r?TD-Linux

Crash fix, patch needed for the libdav1d update to 0.2.1 on beta. Uplift accepted for 67 beta 8, thanks.

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f3907c8d89f9