1538539 - Crash in [@ mdb_txn_renew0]

Status: RESOLVED WORKSFORME

(Core :: SQLite and Embedded Database Bindings, defect, P2)

Description

[Calixte Denizet (:calixte)]

This bug is for crash report bp-f7526401-1bc4-49b4-9a62-306680190324.

Top 10 frames of crashing thread:

0 libxul.so mdb_txn_renew0 third_party/rust/lmdb-rkv-sys/lmdb/libraries/liblmdb/mdb.c:2739
1 libxul.so <name omitted> third_party/rust/lmdb-rkv-sys/lmdb/libraries/liblmdb/mdb.c:2907
2 libxul.so rkv::env::Rkv::read third_party/rust/lmdb-rkv/src/transaction.rs:132
3 libxul.so cert_storage::SecurityState::read_entry security/manager/ssl/cert_storage/src/lib.rs:167
4 libxul.so cert_storage::CertStorage::allocate::GetRevocationState security/manager/ssl/cert_storage/src/lib.rs:231
5 libxul.so mozilla::psm::NSSCertDBTrustDomain::GetCertTrust security/certverifier/NSSCertDBTrustDomain.cpp:213
6 libxul.so mozilla::pkix::CheckIssuerIndependentProperties security/nss/lib/mozpkix/lib/pkixcheck.cpp:966
7 libxul.so mozilla::pkix::BuildForward security/nss/lib/mozpkix/lib/pkixbuild.cpp:311
8 libxul.so mozilla::psm::BuildCertChainForOneKeyUsage security/nss/lib/mozpkix/lib/pkixbuild.cpp:413
9 libxul.so mozilla::psm::CertVerifier::VerifyCert security/certverifier/CertVerifier.cpp:705

There is 1 crash in nightly 68 with buildid 20190323094805. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1429796.

[1] https://hg.mozilla.org/mozilla-central/rev?node=5514aae0e34e

Comment 1

[Mark Goodwin [:mgoodwin]]

Myk, this looks like it's probably an rkv/lmdb thing?

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Yes, it's an LMDB issue. The code that triggered the crash was added in ITS#7970 (https://www.openldap.org/lists/openldap-bugs/201410/msg00051.html), although the bug may not be caused by that change, as LMDB was setting r->mr_txnid = ti->mti_txnid beforehand (it just wasn't setting it repeatedly before that change).

I'll investigate further…

Comment 3

[Julien Cristau [:jcristau]]

We still have just the 1 crash report after a month, this doesn't seem too common.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.