Closed Bug 1538695 Opened 5 years ago Closed 5 years ago

switch autoland repo pushes to be in the public state

Categories

(Developer Services :: Mercurial: hg.mozilla.org, task, P1)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: kmoir, Assigned: sheehan)

References

Details

From aryx:

The autoland repository has a “special” configuration: Until its changesets are merged into mozilla-central, they are in the mercurial ‘draft’ phase which allows to alter them easily but also confuses parts of the tooling (Arcanist diff command regards all changes in the draft phase as new and wants to submit them to Phabricator, Mercurial stripping will remove it or requires a special syntax compared to other trees). The plan was to remove pushes for changes which landed and got backed out before they got merged. This would require to run CI jobs for descendants (with new history) again to reflect the correct state of jobs and performance data with the problematic changes not applied. Is this still planned despite the goal of cost savings? If not, are there any objections to switch autoland pushes directly into the public state?

I talked to smacleod about this and he said that it would be fine to change this repo to have pushes directly in the public state. This is the bug to do this work. Please note I'm going to make an announcement about this on relevant mailing lists before implementation should take place.

Tom brought this bug up in our team meeting today, and pointed out that it's a trivial bug to fix that would noticeably improve the user experience interacting with autoland. Let's move this up in priority.

(In reply to Kim Moir [:kmoir] ET from comment #0)

Please note I'm going to make an announcement about this on relevant mailing lists before implementation should take place.

Kim, when you have some time after returning from PTO, could you send out the announcements so we can make this change. Thanks! :)

Assignee: nobody → sheehan
Status: NEW → ASSIGNED
Type: enhancement → task
Flags: needinfo?(kmoir)
Priority: -- → P1

I wrote this draft announcement. I'm not sure if most developers need this level of detail
https://docs.google.com/document/d/1MT77c3JO4vT3rV96FhUa3STbQIxzhfYUfu0inqT8R_Q/edit

(In reply to Kim Moir [:kmoir] ET from comment #2)

I wrote this draft announcement. I'm not sure if most developers need this level of detail
https://docs.google.com/document/d/1MT77c3JO4vT3rV96FhUa3STbQIxzhfYUfu0inqT8R_Q/edit

I left a few nits, but otherwise it looks perfect. 👍

A couple of things that might be valuable to add:

  • Saying that if you don't pull from autoland, this doesn't impact you.
  • Probably the main benefit to developers is that if they do hg wip after pulling autoland, it will no longer blow up

Note sent to dev-platform (may be moderated so a delay in sending?). Anyways, please conduct the change tommorrow and then we can close this bug!

Flags: needinfo?(kmoir)

autoland is now publishing.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.