1538698 - [tc-github] "Bad credentials"

Status: RESOLVED DUPLICATE of bug 1631099

(Taskcluster :: Services, enhancement)

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

We're occasionally getting "Bad credentials" comments for pushes and PRs.

Looking in the logs, this seems to be coming from Github via octokit.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Screenshot_2019-03-25 Update dependency raw-loader to v2 · taskcluster taskcluster aed11bb.png

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Screenshot_2019-03-25 Logs Viewer - heroku-logging - Google Cloud Platform.png

Scrolling back in these logs, it seems the Webhook from Github arrived at 13:34:36 as well. So while I recall that some of the credentials used in app authentication have a very short lifetime, I don't think this is an issue of the credentials timing out.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

https://console.cloud.google.com/logs/viewer?project=heroku-logging&minLogLevel=0&expandAll=false&timestamp=2019-03-25T13%3A38%3A34.532000000Z&customFacets&limitCustomFacetWidth=true&dateRangeStart=2019-03-25T12%3A39%3A21.391Z&dateRangeEnd=2019-03-25T13%3A39%3A21.391Z&interval=PT1H&resource=gce_instance%2Finstance_id%2Fheroku&scrollTimestamp=2019-03-25T13%3A34%3A36.723665000Z&advancedFilter=resource.type%3D%22gce_instance%22%0Aresource.labels.instance_id%3D%22heroku%22%0AlogName%3D%22projects%2Fheroku-logging%2Flogs%2Fgithub%22&pinnedLogId=yeul4bg1mxzs9b&pinnedLogTimestamp=2019-03-25T13%3A34%3A36.715829Z

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

This is still happening occasionally, e.g., https://github.com/taskcluster/taskcluster/commit/6a62be99d388a081e9f35a2703f5d1db5a384849

I wonder if we should retry on this error?

Comment 7

[[:owlish] 🦉 PST]

We recently had a surge of these errors. I'm not sure if the reasons are the same for both bugs, so I'll re-open the one that's urgent, and leave this one as mentored enhancement bug

Comment 8

[[:owlish] 🦉 PST]

(In reply to Dustin J. Mitchell [:dustin] (he/him) from comment #5)

I wonder if we should retry on this error?

To answer the question, the retry had already been implemented by bstack at the time of filing the bug

Comment 9

[Chris Cooper [:coop] (he/him)]

Duping this forward. There should not be two bugs for this. That's confusing.