1538710 - Document splitting followup: remove gfx.webrender.debug.texture-cache.disable-shrink pref

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Alex Thayer [:alexical] (she/her)]

This pref was created as a temporary workaround for TextureCache::clear_kind not being document-aware. The proper fix for this as discussed with bholley is to have a WR API endpoint which allows sending multiple transactions at a time, in order to generate frames for multiple documents in one call. Then, we can run cleanup operations like TextureCache::clear_kind before all document frames, and generate frames for each of the documents if necessary.

I have patches sitting around that get us halfway there, so I'm assigning this to myself.

Comment 1

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1538710 - Add WR API endpoint for sending multiple transactions r?nical

We discussed this a bit in Orlando. Essentially, we want to run cleanup
operations in texture_cache before all documents' frames, and then be
able to ensure that every document generates a frame, because otherwise
we will run into problems with evicted cache items used by non-updating-
but-still-rendering documents. Accordingly, we need an endpoint to
lump all of the transactions that generate frames together. This adds
that and builds out all of the plumbing necessary.

Comment 2

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1538710 - Move texture_cache cleanup to beginning of all frames r?bholley

... and ensure that, if we do cleanup, we generate frames for every document.

Depends on D25132

Comment 3

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1538710 - Remove disable-shrink pref r?bholley

Depends on D25133

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/585b51bba30d
Add WR API endpoint for sending multiple transactions r=nical
https://hg.mozilla.org/integration/autoland/rev/f5f916011032
Move texture_cache cleanup to beginning of all frames r=bholley
https://hg.mozilla.org/integration/autoland/rev/9a80bc4d626a
Remove disable-shrink pref r=bholley

Comment 5

[Dorel Luca [:dluca]]

Backed out 3 changesets (bug 1538710) for Wrench bustage. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238831668&repo=autoland&lineNumber=2985

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=238822442&revision=9a80bc4d626a74d84ae9b4163021d1dcbc585a24

Backout:
https://hg.mozilla.org/integration/autoland/rev/28a607fe5e9b85e81c20c361f4ccf563ae241293

Comment 6

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1538710 - Regen wrench reftest images r?kats

These are trivially different. I couldn't find a cause for the
difference, so I am just regenerating them.

Depends on D25134

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab2083ff97f4
Add WR API endpoint for sending multiple transactions r=nical
https://hg.mozilla.org/integration/autoland/rev/afa5cc2c6032
Move texture_cache cleanup to beginning of all frames r=bholley
https://hg.mozilla.org/integration/autoland/rev/1a529f967061
Remove disable-shrink pref r=bholley
https://hg.mozilla.org/integration/autoland/rev/6f3f506c7740
Regen wrench reftest images r=kats

Comment 8

[Daniel Varga [:dvarga]]

Backed out 4 changesets (Bug 1538710) for webrender-lint

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=240426374&revision=6f3f506c7740f7682a84ba336a198cc3e94fa490

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=240426374&revision=fca4cf358f16453028169b84964ce7dc940bde60

Failure link: https://treeherder.mozilla.org/logviewer.html#?job_id=240432612&repo=autoland

[task 2019-04-15T19:56:47.029Z] ./webrender_api/src/api.rs:1255: space before } is not a multiple of 4
[task 2019-04-15T19:56:47.051Z]
[task 2019-04-15T19:56:47.135Z] Progress: 99% (912/913)
[task 2019-04-15T19:56:47.141Z] Progress: 100% (913/913)
[task 2019-04-15T19:56:47.141Z] Running the dependency licensing lint...
[task 2019-04-15T19:56:47.141Z]
[taskcluster 2019-04-15 19:56:52.972Z] === Task Finished ===
[taskcluster 2019-04-15 19:56:52.972Z] Unsuccessful task run with exit code: 1 completed in 42.151 seconds

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2acb3832e7e5
Backed out 4 changesets for webrender-lint

Comment 10

[Alex Thayer [:alexical] (she/her)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eaf609a0b8d691fc497b1297e0fba82bfc3afb6f

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d88be60f4519
Add WR API endpoint for sending multiple transactions r=nical
https://hg.mozilla.org/integration/autoland/rev/4911ed11603a
Move texture_cache cleanup to beginning of all frames r=bholley
https://hg.mozilla.org/integration/autoland/rev/7135525f4d5a
Remove disable-shrink pref r=bholley
https://hg.mozilla.org/integration/autoland/rev/a5ccc6802a97
Regen wrench reftest images r=kats

Comment 12

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d88be60f4519
https://hg.mozilla.org/mozilla-central/rev/4911ed11603a
https://hg.mozilla.org/mozilla-central/rev/7135525f4d5a
https://hg.mozilla.org/mozilla-central/rev/a5ccc6802a97