1538760 - Error report from checkstyle is empty.

Status: RESOLVED FIXED

(GeckoView :: General, defect, P2)

Description

[[ex-Mozilla] Agi Sferro | :agi]

When checkstyle errors out the errors are not clearly displayed in try runs or when running from console. Also the report does not contain the errors.

E.g. see this example: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ec073adab20e34c13124aede8f5b88adc75b3f57&selectedJob=235880104

where the output is just:

EST-UNEXPECTED-FAIL | android-checkstyle | Checkstyle rule violations were found. See the report at: https://queue.taskcluster.net/v1/task/KyM9tzPnR5-kr8oI7700iw/runs/0/artifacts/public/android/checkstyle/checkstyle.html
Return code: 1
1 not in success codes: [0]
Halting on failure while running ['/usr/bin/python2.7', 'mach', '--log-no-times', 'android', 'checkstyle']
Running post_fatal callback...
Exiting 2
# TBPL FAILURE #
# TBPL FAILURE #

and the report is empty.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1538760 - Parse all output from checkstyle.

Previously |mach android checkstyle| would only parse one file output form
checkstyle (the app one).

This change makes it so it parses all files, also it reduces noise by
suppressing most output when the test passes.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1af13eab194c
Parse all output from checkstyle. r=nalexander

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1af13eab194c