1538764 - Enable ESLint rule no-throw-literal in gfx/

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Ian Moody [:Kwan] (UTC+0)]

no-throw-literal helps ensure that when we do throw errors, they come with stack traces that help track down the source of the error.

Comment 1

[Ian Moody [:Kwan] (UTC+0)]

Attachment: Bug 1538764 - gfx/ automated ESLint no-throw-literal fixes. r=hiro

Result of running:
$ mach eslint -funix gfx/ | sed -Ee 's/:.+//' - | xargs sed -E
-e 's/throw ((["])[^"]+\2);/throw new Error(\1);/g' \ -e 's/throw ((["])[^"]+\2 + [^ ";]+);/throw new Error(\1);/g'
-e 's/throw (/throw new Error(/g' -i

Comment 2

[Ian Moody [:Kwan] (UTC+0)]

Attachment: Bug 1538764 - gfx/ manual ESLint no-throw-literal fixes. r=hiro

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f755066901eb
gfx/ automated ESLint no-throw-literal fixes. r=kats
https://hg.mozilla.org/integration/autoland/rev/a20d8267e39f
gfx/ manual ESLint no-throw-literal fixes. r=kats

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/f755066901eb
https://hg.mozilla.org/mozilla-central/rev/a20d8267e39f