Closed Bug 1538785 Opened 5 years ago Closed 5 years ago

windows/aarch64 - plugin tests failing on windows10-aarch64

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox68 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: egao, Assigned: egao)

References

Details

Attachments

(2 files)

Bug 1538785 - disable plugin-related tests from windows10-aarch64
47 bytes, text/x-phabricator-request
Details | Review
Bug 1538785 - disable additional plugin tests for window10-aarch64
47 bytes, text/x-phabricator-request
Details | Review

Recently many plugin tests for windows10-aarch64 have been failing unexpectedly, and this is a new development over the last two weeks.

Using test_bug427744 as an example of a plugin test, I've narrowed down the range of time as follows:

Last passed (March 18, 2019 23:52 UTC): https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&searchStr=opt-mochitest-e10s-3%2Cm-e10s&revision=eb112723d96e2dace04e29e972864228fba4ece3&selectedJob=234669248
First failure (March 19, 2019 05:11 UTC): https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&searchStr=opt-mochitest-e10s-3%2Cm-e10s&revision=f629872c5dd691ad9f19b2ca9fc71135c650aa62&selectedJob=234924500

Something changed in the mozilla-central codebase during these two times. The number of plugin tests that fail has been increasing from this time on.

This bug will try to keep a running list of the plugin-related tests that fail on windows10-aarch64.

Running about:plugins shows no plugins installed on the windows10-aarch64 hardware I have on hand.

:cpearce - I'm wondering if something may have changed in the plugin system for windows10-aarch64 variant, perhaps to enable Widevine to function. I don't have any solid leads yet however, though I recall you worked on the Widevine plugin for windows10-aarch64 so I felt you were familiar with it.

Flags: needinfo?(cpearce)

I thought bug 1513287 decided that all plugins would be unsupported on aarch64-windows, unless I'm misunderstanding something.

(In reply to David Major [:dmajor] from comment #2)

I thought bug 1513287 decided that all plugins would be unsupported on aarch64-windows, unless I'm misunderstanding something.

:dmajor - I swear I saw that bug before, but I didn't think too much about it. If plugin support was stripped from windows10-aarch64 then it would make sense that plugin tests are failing.

bug 1513287 only mentions Flash though; is this taken to be equivalent to "all plugins"? If that's the case, it means we'd be prudent to stop running all plugin tests for windows10-aarch64.

Tests that appear to be plugin-related as of try push https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=e2ea6029e57f1ea4853cb193c132b6142a2bb743&selectedJob=235807002:

xpcshell

  • test_gmpProvider.js

mochitest

  • test_plugin_freezing
  • test_bug427744
  • test_ext_clipboard_image
  • test_ext_storage_manager_capabilities

mochitest-browser-chrome

  • browser_ext_port_disconnect_on_crash
  • browser_policy_disable_flash_plugin
  • browser_pluginCrashCommentAndURL
  • browser_pluginCrashReportNonDeterminism
  • test_mixed_case_mime

mochitest-clipboard

  • test_bug1165981

This list is non exhaustive but does give me a starting point if the decision to disable plugin-related tests are made.

As another data point, I took my windows10-aarch64 hardware and ran test_bug427744 which fails consistently in CI environment, in both standalone and in chunks, as well as in the CI environment.

Both attempts were made with current mozilla-central revision 55261bc.

local aarch64 hardware, single test

Test ran and passed without errors.
Checking the browser that was opened by the test script showed various plugins installed for the browser, including Shockwave Flash which ostensibly isn't supported.

local aarch64 hardware, chunks

Test ran and passed without errors.

ci

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=ac803848ccbc63641f85455ebf95a58882fe1c9b
Test ran and fails with TEST-UNEXPECTED-FAIL.

Not sure if we can draw a conclusion from this, but either my local aarch64 hardware is not behaving as expected, or the CI machine(s) are not behaving as expected (with regards to the plugins).

(In reply to Edwin Gao (:egao) from comment #4)

Tests that appear to be plugin-related as of try push https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=e2ea6029e57f1ea4853cb193c132b6142a2bb743&selectedJob=235807002:

xpcshell

  • test_gmpProvider.js

I would not expect test_gmpProvider.js to be broken on aarch64; this test exercises code that is used to download the Widevine CDM, which we're using on aarch64.

I know very little about the other plugins we use, so I can't comment on the other tests here. But test_gmpProvider.js should be working.

Flags: needinfo?(cpearce)

test_gmpProvider.js uses plugins:
https://searchfox.org/mozilla-central/source/toolkit/mozapps/extensions/test/xpcshell/test_gmpProvider.js

if plugins are not supported, why would this test work?

Because we using Gecko Media Plugins on aarch64 to play Netflix. I expect when the decision was made to "not support plugins on aarch64", the decision makers were thinking of Flash, Silverlight, Java Applets, etc, and not OpenH264 and Widevine, which are definitely intended to be supported.

:cpearce, can you work on fixing the test_gmpProvider.js test case then? Otherwise we need to disable it before turning the tests on which we plan to do next week.

Flags: needinfo?(cpearce)

I verified on try that bug 1530507 did in fact cause tests to start failing. Not all plugin tests were passing before, for example in the clipboard job, this test was failing prior to disabling plugins:
dom/plugins/test/mochitest/test_windowless_ime.html

:jimm, can you validate the tests in comment 4 need to be disabled (except for test_gmpProvider.js)? Are there other tests? Can we just disable any test that references plugins?

Flags: needinfo?(jmathies)

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #11)

I verified on try that bug 1530507 did in fact cause tests to start failing.
Not all plugin tests were passing before, for example in the clipboard job,
this test was failing prior to disabling plugins:
dom/plugins/test/mochitest/test_windowless_ime.html

:jimm, can you validate the tests in comment 4 need to be disabled (except
for test_gmpProvider.js)? Are there other tests? Can we just disable any
test that references plugins?

Yeah I killed off plugin support in bug bug 1530507 through prefs. All (non-gmp) related tests should be disabled.

Flags: needinfo?(jmathies)
Depends on: 1530507

Thanks :jimm, we will turn off all the other tests that depend on plugins except gmp specific ones.

Pushed by egao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c1e131231c02
disable plugin-related tests from windows10-aarch64 r=jmaher
Pushed by egao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d01e4eb64768
disable additional plugin tests for window10-aarch64 r=jmaher

https://hg.mozilla.org/mozilla-central/rev/c1e131231c02
https://hg.mozilla.org/mozilla-central/rev/d01e4eb64768

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → egao
Flags: needinfo?(cpearce)
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: