1538805 - Gamepad only can be shown up in a single tab when visiting to multiple Gamepad tabs.

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect, P1)

Description

[Daosheng Mu[:daoshengmu]]

STP:

1. Open a tab and visit https://html5gamepad.com/
2. Press buttons or push axes to make this tab recognizes the gamepad is connected.
3. Open an another tab and visit https://html5gamepad.com/
4. We can find in the second tab, our gamepad can not be recognized.

I have checked FF on Windows and Mac OS. Both of them have the same result.

Comment 1

[Zac]

I am experiencing this issue after updating, I wanted to include some additional information from debugging/troubleshooting.

This issue was introduced in release 56.0.0
Disabling browser.tabs.remote.autostart fixes the issue.

navigator.getGamepads in the second window seems to return an empty list

Comment 2

[Daosheng Mu[:daoshengmu]]

(In reply to Zac from comment #1)

I am experiencing this issue after updating, I wanted to include some additional information from debugging/troubleshooting.

This issue was introduced in release 56.0.0
Disabling browser.tabs.remote.autostart fixes the issue.

navigator.getGamepads in the second window seems to return an empty list

Good to know! I guess we need to handle the case of multiple content processes.

Comment 3

[Daosheng Mu[:daoshengmu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b8dabcef05394a363e2daafc113a3c61490b4ffc try looks good now and confirmed my local patch fixes this issue. Once I am done with rebasing, we can start to review.

Comment 4

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1538805 - Send GamepadAdded events to the later GamepadEventChannels.

Comment 5

[Daosheng Mu[:daoshengmu]]

The original issue was happened when only sending GamepadAdded events to the first GamepadEventChannel. That makes the later content processes would not have the existing gamepad objects. Therefore, I think we should send extra GamepadAdded events for the later GamepadEventChannels.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df539e0d6851
Send GamepadAdded events to the later GamepadEventChannels. r=baku

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/df539e0d6851