use AppendMessage() for ForceShutDown()
Categories
(Core :: Audio/Video: MediaStreamGraph, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: karlt, Assigned: karlt)
References
Details
Attachments
(2 files)
Using AppendMessage() keeps shutdown in order with other messages, and so provides that control messages sent to the graph before shutdown are run on the graph thread. This is useful for Worklet shutdown for bug 1539039.
|
Assignee | |
Comment 1•5 years ago
|
||
These are unnecessary because non-empty !mRealtime graphs also set
mForcedShutDown before progressing to
LIFECYCLE_WAITING_FOR_MAIN_THREAD_CLEANUP.
This reverts some of
https://hg.mozilla.org/mozilla-central/rev/d0d427badc22afa7d5406e4e376bf27df0c0aaba#l1.72
which is possible because a non-realtime graph no longer progresses to
LIFECYCLE_WAITING_FOR_MAIN_THREAD_CLEANUP when it reaches mEndTime since
https://hg.mozilla.org/mozilla-central/rev/61d08765489c#l1.41
|
|
Assignee | |
Comment 2•5 years ago
|
||
instead of special signaling, which can get out of order with other messages.
Using AppendMessage() provides that control messages sent to the graph before
shutdown are run on the graph thread.
Depends on D24855
|
||
Updated•5 years ago
|
Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6c126334dae3 remove unnecessary !mRealtime checks with mForcedShutDown r=padenot https://hg.mozilla.org/integration/autoland/rev/a51041f61c2c use AppendMessage() for ForceShutDown() r=padenot
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6c126334dae3
https://hg.mozilla.org/mozilla-central/rev/a51041f61c2c
Description
•