1539104 - Intermittent GECKO(849) | Assertion failure: false (Don't use async connections synchronously on the main thread), at /builds/worker/workspace/build/src/storage/mozStorageConnection.cpp:940

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect, P5)

Description

[Treeherder Bug Filer]

#[markdown(off)]
Filed by: ncsoregi [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=236060117&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/Z6-xagsmQUOgkG5rAOi6QA/runs/0/artifacts/public/logs/live_backing.log

08:27:02 INFO - TEST-OK | browser/components/enterprisepolicies/tests/browser/disable_default_bookmarks/browser_policy_no_default_bookmarks.js | took 64ms
08:27:02 INFO - GECKO(849) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /var/folders/qb/nc1k_bf97hzdn4_8gyj23zpr00000x/T/tmpCAEAt2.mozrunner/runtests_leaks_tab_pid854.log
08:27:02 INFO - GECKO(849) | ++DOMWINDOW == 3 (0x1249ce800) [pid = 853] [serial = 3] [outer = 0x124931020]
08:27:02 INFO - checking window state
08:27:02 INFO - GECKO(849) | ++DOMWINDOW == 12 (0x13094d800) [pid = 849] [serial = 12] [outer = 0x1222bfa60]
08:27:02 INFO - Console message: [JavaScript Error: "TypeError: reply[0] is undefined" {file: "chrome://marionette/content/listener.js" line: 453}]
08:27:02 INFO - GECKO(849) | ++DOMWINDOW == 13 (0x134c5c400) [pid = 849] [serial = 13] [outer = 0x1222bfa60]
08:27:02 INFO - GECKO(849) | [Parent 849, Main Thread] WARNING: 'aOperation == SYNCHRONOUS && mSupportedOperations == ASYNCHRONOUS && NS_IsMainThread()', file /builds/worker/workspace/build/src/storage/mozStorageConnection.cpp, line 938
08:27:02 INFO - GECKO(849) | Assertion failure: false (Don't use async connections synchronously on the main thread), at /builds/worker/workspace/build/src/storage/mozStorageConnection.cpp:940
08:28:33 INFO - GECKO(849) | #01: mozilla::storage::Service::minimizeMemory() [xpcom/base/nsCOMPtr.h:439]
08:28:33 INFO -
08:28:33 INFO - GECKO(849) | #02: mozilla::storage::Service::Observe(nsISupports*, char const*, char16_t const*) [storage/mozStorageService.cpp:0]
08:28:33 INFO -
08:28:33 INFO - GECKO(849) | #03: non-virtual thunk to mozilla::storage::Service::Observe(nsISupports*, char const*, char16_t const*) [storage/mozStorageService.cpp:0]
08:28:33 INFO -
08:28:33 INFO - GECKO(849) | #04: nsObserverList::NotifyObservers(nsISupports*, char const*, char16_t const*) [xpcom/ds/nsObserverList.cpp:65]
08:28:33 INFO -
08:28:33 INFO - GECKO(849) | #05: nsObserverService::NotifyObservers(nsISupports*, char const*, char16_t const*) [mozglue/misc/TimeStamp.h:452]
08:28:33 INFO -
08:28:33 INFO - GECKO(849) | --DOMWINDOW == 3 (0x1143a7000) [pid = 851] [serial = 2] [outer = 0x0] [url = about:blank]
08:28:33 INFO - GECKO(849) | Exiting due to channel error.
08:28:33 INFO - GECKO(849) | Exiting due to channel error.
08:28:33 INFO - GECKO(849) | Exiting due to channel error.
08:28:33 INFO - GECKO(849) | Exiting due to channel error.
08:28:33 INFO - GECKO(849) | Exiting due to channel error.
08:28:33 INFO - TEST-INFO | Main app process: exit 1
08:28:33 ERROR - TEST-UNEXPECTED-FAIL | ShutdownLeaks | process() called before end of test suite
08:28:33 INFO - Buffered messages finished
08:28:33 ERROR - TEST-UNEXPECTED-FAIL | Last test finished | application terminated with exit code 1

Comment 1

[Lina Butler [:lina]]

The problem is this cast here: https://searchfox.org/mozilla-central/rev/2c912888e3b7ae4baf161d98d7a01434f31830aa/storage/mozStorageService.cpp#313-314 Both types of connections implement mozIStorageConnection now, whereas before, async connections didn't.

Comment 2

[Lina Butler [:lina]]

Attachment: Bug 1539104 - Add a way to detect supported storage connection operations. r?mak

In retrospect, overloading Connection::connectionReady to mean
"is ready and supports this operation" wasn't a good idea. This
commit reverts that change (cfd44c936a9b), and adds two new methods:

• Connection::operationSupported, to check if a connection supports
  sync or async operations. This method is public.
• Connection::ensureOperationSupported, that asserts or returns an
  error if the connection doesn't support an operation. This is
  private.

operationSupported is used by callers like Service::minimizeMemory
to detect if the connection supports sync operations, since both sync
and async connections implement mozIStorageConnection now.

Finally, some callers used !mDBConn to check if the connection was
ready, while others used connectionReady(). This commit changes them
to use the latter.

Comment 3

[Intermittent Failures Robot]

3 failures in 3910 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-inbound: 2
• mozilla-central: 1

Platform breakdown:

• osx-10-10: 2
• windows10-64-ccov: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1539104&startday=2019-03-25&endday=2019-03-31&tree=all

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db20a3f4324e
Add a way to detect supported storage connection operations. r=mak

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/db20a3f4324e

Comment 6

[Intermittent Failures Robot]

1 failures in 2843 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-inbound: 1

Platform breakdown:

• osx-10-10: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1539104&startday=2019-04-01&endday=2019-04-07&tree=all