Crash in mozilla::gfx::DrawTargetD2D1::CreateBrushForPattern when using Canvas

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
29 days ago
28 days ago

People

(Reporter: bas.schouten, Assigned: bas.schouten)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(firefox66+ fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

29 days ago

There's one more crash left in Canvas with CreateBrushForPattern. This bug is specifically for the beta uplift of one of the patches that has already landed on central in bug 1524554.

(Assignee)

Comment 1

29 days ago
Posted patch D22964.diffSplinter Review

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1519760
  • User impact if declined: Crashes
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just a validity check adding an early return.
  • String changes made/needed: None
Attachment #9053565 - Flags: approval-mozilla-release?
Comment on attachment 9053565 [details] [diff] [review]
D22964.diff

Last crash fix for mozilla::gfx::DrawTargetD2D1::CreateBrushForPattern landed just before the merge to 67. Proced effective on Beta, approved for uplift to our next 66 dot release. Thanks
Attachment #9053565 - Flags: approval-mozilla-release? → approval-mozilla-release+
Status: ASSIGNED → RESOLVED
Last Resolved: 28 days ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.