1539150 - Perma /test_classify_by_default.html | Tracker request img-srcreceived without cookie when Gecko 68 merges to Beta on 2019-05-06

Status: VERIFIED FIXED

(Toolkit :: Safe Browsing, defect, P1)

Description

[Raul Gurzau (:RaulG)]

[Tracking Requested - why for this release]:

Central as Beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=7badcc1ef6947dae9e04cb8b8924dbbda2593a6c&selectedJob=236116471

Log link:https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=236116471&repo=try&lineNumber=13780

Log snippet:

[task 2019-03-26T13:11:45.149Z] 13:11:45 INFO - TEST-PASS | toolkit/components/url-classifier/tests/mochitest/test_classify_by_default.html | Tracker request xmlhttprequestreceived with cookie
[task 2019-03-26T13:11:45.150Z] 13:11:45 INFO - TEST-PASS | toolkit/components/url-classifier/tests/mochitest/test_classify_by_default.html | Tracker request send-beaconreceived with cookie
[task 2019-03-26T13:11:45.150Z] 13:11:45 INFO - Buffered messages finished
[task 2019-03-26T13:11:45.152Z] 13:11:45 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/url-classifier/tests/mochitest/test_classify_by_default.html | Tracker request img-srcreceived without cookie
[task 2019-03-26T13:11:45.152Z] 13:11:45 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
[task 2019-03-26T13:11:45.152Z] 13:11:45 INFO - loadTestFrame/</</<@toolkit/components/url-classifier/tests/mochitest/test_classify_by_default.html:58:11
[task 2019-03-26T13:11:45.153Z] 13:11:45 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-03-26T13:11:45.153Z] 13:11:45 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/url-classifier/tests/mochitest/test_classify_by_default.html | Tracker request object-datareceived without cookie
[task 2019-03-26T13:11:45.153Z] 13:11:45 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
[task 2019-03-26T13:11:45.153Z] 13:11:45 INFO - loadTestFrame/</</<@toolkit/components/url-classifier/tests/mochitest/test_classify_by_default.html:58:11
[task 2019-03-26T13:11:45.156Z] 13:11:45 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-03-26T13:11:45.156Z] 13:11:45 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/url-classifier/tests/mochitest/test_classify_by_default.html | Tracker request script-srcreceived without cookie
[task 2019-03-26T13:11:45.156Z] 13:11:45 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
[task 2019-03-26T13:11:45.157Z] 13:11:45 INFO - loadTestFrame/</</<@toolkit/components/url-classifier/tests/mochitest/test_classify_by_default.html:58:11
[task 2019-03-26T13:11:45.157Z] 13:11:45 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-03-26T13:11:45.158Z] 13:11:45 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/url-classifier/tests/mochitest/test_classify_by_default.html | Tracker request iframe-srcreceived without cookie
[task 2019-03-26T13:11:45.158Z] 13:11:45 INFO - SimpleTest.ok@SimpleTest/SimpleTest.js:275:18
[task 2019-03-26T13:11:45.158Z] 13:11:45 INFO - loadTestFrame/</</<@toolkit/components/url-classifier/tests/mochitest/test_classify_by_default.html:58:11
[task 2019-03-26T13:11:45.159Z] 13:11:45 INFO - Not taking screenshot here: see the one that was previously logged

dimi, this failure seems to be from Bug 1522412, can you please take a look?

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1539150 - Use window.open instead of setting iframe src in test_classify_by_default.html. ?baku

In the test_classify_by_default.html, we use "network.cookie.cookieBehavior"
to test if a channel is correctly classified.

Cookie restriction is only enabled in nightly and early beta so the
default preference is not always set. Although we set the preference
in the testcase, it is too late because that the channel's cookie
setting might inherit from it's parent and may end up with getting
the old(default) value.

In this patch, we use window.open to test the tracker frame to make
sure we use the udpated prefrence.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c083d75f70d4
Use window.open instead of setting iframe src in test_classify_by_default.html. ?baku r=baku

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c083d75f70d4

Comment 5

[Cristina Coroiu [:ccoroiu]]

Verified as fixed with this beta sim:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=f93052ee13bd1c13116d56247edb8a0c4a87a0ce&selectedJob=237825393

Comment 6

[Intermittent Failures Robot]

1 failures in 2843 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1539150&startday=2019-04-01&endday=2019-04-07&tree=all