1539178 - Increase threshold of gamepad joystick activation

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement, P3)

Description

[Tom Ritter [:tjr]]

As discussed on dev-platform, we would like to increase the threshold of joystick activation so that a slightly off joystick or a user typing or bumping their desk with the gamepad on it does not cause the gamepad to activate and be visible to a webpage.

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1539178 - Add a threshold on gamepad axes to avoid gamepads be unintentionally activated.

Comment 2

[Daosheng Mu[:daoshengmu]]

If the gamepad is the first time to be seen, we need to check if its axis move value is larger than AXIS_FIRST_INTENT_THRESHOLD_VALUE, then we will let it pass the first intent judgement.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed7c0b42d735
Add a threshold on gamepad axes to avoid gamepads be unintentionally activated. r=cmartin,baku

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ed7c0b42d735

Comment 5

[Hamish Willee]

Hi :daoshengmu

Did you have any particular documentation requirement in mind? Looking at the docs - e.g. https://developer.mozilla.org/en-US/docs/Web/API/Gamepad_API/Using_the_Gamepad_API this doesn't actually impact the API - it just makes sure that it isn't inadvertently triggered.

If not, I'll just add a release note: https://wiki.developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/81#Gamepad