1539210 - Add support for Target.sendMessageToTarget and Target.receivedMessageFromTarget

Status: RESOLVED FIXED

(Remote Protocol :: CDP, enhancement, P1)

Description

[Alexandre Poirot [:ochameau]]

Target.sendMessageToTarget allows to send a message to a target different from the one you originally connected too when attaching to the HTTP Endpoint.

Typically, Wordpress will use puppetteer in a way where it will connect to /devtools/browser HTTP endpoint. This actually connect to the main process target.

It will then use Target.createTarget to open a new tab and then use Target.attachToTarget to connect to the newly-opened tab's target.

But since they are still using Puppeteer 1.6.1 (Today's upstream version is 1.13.0), they are not using sessions as implemented in bug 1533682.

Instead, they are using Target.sendMessageToTarget and Target.receivedMessageFromTarget to communicate to this target while reusing the same websocket connection. Puppeteer no longer does/supports that.

We could probably help migrating WordPress to run against firefox if we don't force them to update puppeteer. But anyway, these two target methods are documented in many places and are often referenced in chrome-remote-interface as the main way to communicated to new targets. So it would probably help other integration if we implement these method and event.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1539210 - Add support for Target.sendMessageToTarget and Target.receivedMessageFromTarget.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1539210 - Do not destroy the content process session on page unload.

A session is bound to a browsing context, not just one document.
unload is fired when navigating to another document. The document goes
away, but not the browsing context. So, we should keep the session up and running
when the current document is destroyed and we navigate to another URL.

Depends on D25577

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1539210 - Document TabSession and Session constructor arguments.

Depends on D25578

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dea69b276a3f
Add support for Target.sendMessageToTarget and Target.receivedMessageFromTarget. r=ato
https://hg.mozilla.org/integration/autoland/rev/d0558202539c
Do not destroy the content process session on page unload. r=ato
https://hg.mozilla.org/integration/autoland/rev/dfc8060c8b0e
Document TabSession and Session constructor arguments. r=ato

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/dea69b276a3f
https://hg.mozilla.org/mozilla-central/rev/d0558202539c
https://hg.mozilla.org/mozilla-central/rev/dfc8060c8b0e