1539236 - Pocket images are being fetched from the network and not the cache

Status: RESOLVED INVALID

(Firefox :: New Tab Page, enhancement)

Description

[Mike Conley (:mconley) (:⚙️)]

When profiling, I noticed that we send network requests to get the Pocket images in about:home every time the page loads.

Repeated reloads, even with the same set of images, causes the same network requests, every time.

We can probably save some bandwidth for our users (and ourselves!) by reading these images from the network cache by default.

Here's a screencast demonstrating the issue: https://www.screencast.com/t/oGoNgwpJ

Comment 1

[Andrei Oprea [:andreio]]

I am seeing the network requests when refreshing the page but opening new tabs and clicking the home button do not trigger new requests. Is this the expected behavior?

Comment 2

[Andrei Oprea [:andreio]]

Attachment: Screenshot 2019-03-27 at 20.43.50.png

And on a browser restart it seems that we hit the cache.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

(In reply to Andrei Oprea [:andreio] from comment #1)

I am seeing the network requests when refreshing the page but opening new tabs and clicking the home button do not trigger new requests. Is this the expected behavior?

The preloading of about:newtab we do might be confusing things at least for the tab-opening case - you can disable that via browser.newtab.preload.

If we're hitting the cache on start-up, and on opening tabs / windows, and when hitting "Home", then this is probably an INVALID bug. It probably makes sense to hit the network if the user hits Reload.

Comment 4

[Andrei Oprea [:andreio]]

Tested:

• opening tabs
• windows
• home button
• startup

With preload disabled. No network calls.