Closed Bug 1539261 Opened 7 months ago Closed 7 months ago

Mark JSStructuredCloneData methods MOZ_MUST_USE

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

Attachments

(2 files)

No description provided.

I split out the first patch because it is a little weird, so it feels like having somebody familiar with the particular code looking at it would be good.

The second place doesn't return an error because that's what some
earlier code in the method does. Hopefully that is ok.

Also, fix up various places that call these methods.

Depends on D24991

Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b070b6ae224
part 1 - IndexedDB changes. r=asuth
https://hg.mozilla.org/integration/autoland/rev/526daf87fff9
part 2 - Mark various JSStructuredCloneData methods MOZ_MUST_USE. r=sfink

Oops. Looks like SearchFox doesn't index that directory and also it doesn't build in a regular build...

Flags: needinfo?(continuation)

Steve, do you know how I can build this fuzztarget locally? I can probably grep my way to victory here but I'd rather be able to test it locally.

Flags: needinfo?(sphink)

Well, it looks like there are only those two function calls, so I'll just fix those and hope for the best.

Flags: needinfo?(sphink)
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/054cbaead303
part 1 - IndexedDB changes. r=asuth
https://hg.mozilla.org/integration/autoland/rev/ebcc9bb7c50a
part 2 - Mark various JSStructuredCloneData methods MOZ_MUST_USE. r=sfink
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

(In reply to Andrew McCreight [:mccr8] from comment #7)

Steve, do you know how I can build this fuzztarget locally? I can probably grep my way to victory here but I'd rather be able to test it locally.

Sorry for the delay. The simplest way would be to run js/src/devtools/automation/autospider.py fuzzing. More manually than that, you can look at js/src/devtools/automation/variants/fuzzing which gives:

{
"configure-args": "--enable-fuzzing --enable-debug-symbols='-gline-tables-only -gdwarf-2' --disable-jemalloc --disable-stdcxx-compat --enable-address-sanitizer --enable-ctypes --enable-nspr-build",
"optimize": true,
"debug": false,
"compiler": "clang",
"env": {
"JITTEST_EXTRA_ARGS": "--jitflags=none",
"JSTESTS_EXTRA_ARGS": "--jitflags=none",
"LLVM_SYMBOLIZER": "{TOOLTOOL_CHECKOUT}/clang/bin/llvm-symbolizer",
"ASAN_SYMBOLIZER_PATH": "{TOOLTOOL_CHECKOUT}/clang/bin/llvm-symbolizer"
},
"use_minidump": false
}

so hopefully running configure with those args (and --enable-optimize --disable-debug for completeness) should do it.

Regressions: 1545196
You need to log in before you can comment on or make changes to this bug.