Closed
Bug 1539355
Opened 6 years ago
Closed 6 years ago
Don't package addons in resource directories as XPI in OmnijarFormatter
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox68 fixed)
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(3 files)
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
This demonstrates how addons positioned under a resource directory (a
directory that would normally go in omni.ja) is currently treated.
|
|
Assignee | |
Comment 2•6 years ago
|
||
Practically speaking, it makes no difference, as only the calls to
add_base from tests weren't already ordered.
This allows a simpler approach for next change.
|
|
Assignee | |
Comment 3•6 years ago
|
||
The addons manager is going to support this usecase.
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/1463643557fc Add a packager test for in-resource addons. r=nalexander https://hg.mozilla.org/integration/autoland/rev/0f96b37a1e34 Force callers of *Formatter.add_base to order their bases. r=nalexander https://hg.mozilla.org/integration/autoland/rev/2ba58db65271 Don't package addons in resource directories as XPI in OmnijarFormatter. r=nalexander
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1463643557fc
https://hg.mozilla.org/mozilla-central/rev/0f96b37a1e34
https://hg.mozilla.org/mozilla-central/rev/2ba58db65271
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/ac337210f180 Followup for bug 1539355: Make it work for the root directory. r=me
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•