1539393 - TransactionDatabaseOperationBase::ActorDestroy doesn't check if we are waiting for the Continue message

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect, P2)

Description

[Jan Varga [:janv]]

Like bug 1538619, this can help to reduce number of intermittent failures, crashes, hangs.
However, WASM in IDB is not used much and is actually being removed (it's not possible to store WASM in IDB anymore, but old databases can still trigger sending of the Preprocess message).
We should rather fix this using a similar approach as in bug 1533789.

Comment 1

[Jan Varga [:janv]]

Yes, this can cause a rare shutdown hang too.
If it happens, the crash annotation is "gLiveDatabaseHashtable: N"
See bug 1542478 comment 2.

I have a patch for this.

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1539393 - TransactionDatabaseOperationBase::ActorDestroy doesn't check if we are waiting for the Continue message; r=asuth

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2a538f6c3c90d5241946d7ab071231fcc46fa86
https://hg.mozilla.org/mozilla-central/rev/a2a538f6c3c9

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider for Beta uplift?

Comment 5

[Jan Varga [:janv]]

Yes, will request approval.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Jan, want to request uplift to beta for 67?

Comment 7

[Pascal Chevrel:pascalc]

Jan, I am not seeing crashes with 67 beta but note that our last beta is this week if you think it needs to be uplifted to 67 before we ship.

Comment 8

[Jan Varga [:janv]]

Comment on attachment 9058083 [details]
Bug 1539393 - TransactionDatabaseOperationBase::ActorDestroy doesn't check if we are waiting for the Continue message; r=asuth

Beta/Release Uplift Approval Request

• User impact if declined: Users can experience crashes if IndexedDB was used to stored WASM.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple patch, verified on Nightly (landed 17 days ago).
• String changes made/needed: None

Comment 9

[Jan Varga [:janv]]

Sorry for the delay, it would be good to have this patch in 67 for correctness.

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9058083 [details]
Bug 1539393 - TransactionDatabaseOperationBase::ActorDestroy doesn't check if we are waiting for the Continue message; r=asuth

Uplift approved for the beta branch.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/76d84e7aeb3ffc34d0d52cc4adc89bd6ddd0c2e7