Closed Bug 1539407 Opened 5 years ago Closed 5 years ago

Use the correct global for DOMEventTargetHelper in IndexedDB

Categories

(Core :: Storage: IndexedDB, enhancement)

Product:
Core
Component:
Storage: IndexedDB
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file)

Bug 1539407 - Use the correct global for DOMEventTargetHelper in IndexedDB, r?smaug
47 bytes, text/x-phabricator-request
Details | Review

IndexedDB uses a valid nsIGlobalObject as parent only when its factory is owned by a window. We need to extend this concept to workers and JSM.
This blocks bug 1455020.

Thank you for getting rid of IDBWrapperCache!!

Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/98452610cfcc
Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug

Backed out changeset 98452610cfcc (Bug 1539407) for browser-chrome failure at /builds/worker/workspace/build/src/dom/indexedDB/IDBRequest.cpp:284. On a CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=98452610cfcc81cba0d4478797fe1e83a51172e8

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=236914811&repo=autoland&lineNumber=14350

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=2cbcf3ac7ca69ca7717c8a8232b293f75ef2ca8a

[task 2019-03-29T15:21:05.446Z] 15:21:05 INFO - GECKO(4718) | ++DOMWINDOW == 13 (0xe7170000) [pid = 4889] [serial = 68] [outer = 0xf7167df0]
[task 2019-03-29T15:21:05.816Z] 15:21:05 INFO - GECKO(4718) | [Parent 4718, GMPThread] WARNING: Failed to delete GMP storage directory: file /builds/worker/workspace/build/src/dom/media/gmp/GMPServiceParent.cpp, line 1569
[task 2019-03-29T15:21:05.982Z] 15:21:05 INFO - GECKO(4718) | Assertion failure: GetOwnerGlobal(), at /builds/worker/workspace/build/src/dom/indexedDB/IDBRequest.cpp:284
[task 2019-03-29T15:21:05.985Z] 15:21:05 INFO - GECKO(4718) | #01: mozilla::dom::IDBRequest::SetResultCallback(mozilla::dom::IDBRequest::ResultCallback*) [mfbt/Assertions.h:38]
[task 2019-03-29T15:21:05.987Z] 15:21:05 INFO -
[task 2019-03-29T15:21:05.988Z] 15:21:05 INFO - GECKO(4718) | #02: mozilla::dom::indexedDB::(anonymous namespace)::DispatchSuccessEvent(mozilla::dom::indexedDB::(anonymous namespace)::ResultHelper*, mozilla::dom::Event*) [dom/indexedDB/ActorsChild.cpp:742]
[task 2019-03-29T15:21:05.990Z] 15:21:05 INFO -
[task 2019-03-29T15:21:05.991Z] 15:21:05 INFO - GECKO(4718) | #03: mozilla::dom::indexedDB::BackgroundDatabaseChild::RecvPBackgroundIDBVersionChangeTransactionConstructor(mozilla::dom::indexedDB::PBackgroundIDBVersionChangeTransactionChild*, unsigned long long const&, unsigned long long const&, long long const&, long long const&) [ipc/glue/ProtocolUtils.h:377]
[task 2019-03-29T15:21:05.992Z] 15:21:05 INFO -
[task 2019-03-29T15:21:05.992Z] 15:21:05 INFO - GECKO(4718) | #04: mozilla::dom::indexedDB::PBackgroundIDBDatabaseChild::OnMessageReceived(IPC::Message const&) [s3:gecko-generated-sources:6dad620e5013577630a5a54995424b25d16b50a9ae4e31211ea070b5a58698f63d2e316bc3484ae4a85ce138b2a64a191a9fe89bc800fa1c6c6df25d69828fa0/ipc/ipdl/PBackgroundIDBDatabaseChild.cpp::595]
[task 2019-03-29T15:21:05.992Z] 15:21:05 INFO -
[task 2019-03-29T15:21:05.992Z] 15:21:05 INFO - GECKO(4718) | #05: mozilla::ipc::PBackgroundChild::OnMessageReceived(IPC::Message const&) [s3:gecko-generated-sources:dcba793814c557dd7fb3d18f09ca726da67137e3dd103ea86de04a710db209a2ec6d5e7e956e810f76c65cc538711ed50daecf9eafb80cae7dd0307c61c12b4c/ipc/ipdl/PBackgroundChild.cpp::2752]
[task 2019-03-29T15:21:05.992Z] 15:21:05 INFO -
[task 2019-03-29T15:21:05.992Z] 15:21:05 INFO - GECKO(4718) | #06: mozilla::ipc::MessageChannel::DispatchAsyncMessage(IPC::Message const&) [ipc/glue/MessageChannel.h:651]
[task 2019-03-29T15:21:05.992Z] 15:21:05 INFO -
[task 2019-03-29T15:21:05.992Z] 15:21:05 INFO - GECKO(4718) | #07: mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) [ipc/glue/MessageChannel.cpp:2080]
[task 2019-03-29T15:21:05.993Z] 15:21:05 INFO -
[task 2019-03-29T15:21:05.995Z] 15:21:05 INFO - GECKO(4718) | #08: mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&) [ipc/glue/MessageChannel.cpp:0]
[task 2019-03-29T15:21:05.995Z] 15:21:05 INFO -
[task 2019-03-29T15:21:05.995Z] 15:21:05 INFO - GECKO(4718) | #09: mozilla::ipc::MessageChannel::MessageTask::Run() [xpcom/threads/Monitor.h:34]
[task 2019-03-29T15:21:05.996Z] 15:21:05 INFO -
[task 2019-03-29T15:21:05.997Z] 15:21:05 INFO - GECKO(4718) | #10: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1167]
[task 2019-03-29T15:21:05.997Z] 15:21:05 INFO -
[task 2019-03-29T15:21:06.002Z] 15:21:06 INFO - GECKO(4718) | #11: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:482]
[task 2019-03-29T15:21:06.002Z] 15:21:06 INFO -
[task 2019-03-29T15:21:06.003Z] 15:21:06 INFO - GECKO(4718) | #12: mozilla::dom::WorkerPrivate::DoRunLoop(JSContext*) [mfbt/RefPtr.h:267]
[task 2019-03-29T15:21:06.003Z] 15:21:06 INFO -
[task 2019-03-29T15:21:06.005Z] 15:21:06 INFO - GECKO(4718) | #13: mozilla::dom::workerinternals::(anonymous namespace)::WorkerThreadPrimaryRunnable::Run() [dom/workers/RuntimeService.cpp:2308]
[task 2019-03-29T15:21:06.005Z] 15:21:06 INFO -
[task 2019-03-29T15:21:06.006Z] 15:21:06 INFO - GECKO(4718) | #14: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1167]
[task 2019-03-29T15:21:06.006Z] 15:21:06 INFO -
[task 2019-03-29T15:21:06.007Z] 15:21:06 INFO - GECKO(4718) | #15: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:482]
[task 2019-03-29T15:21:06.008Z] 15:21:06 INFO -
[task 2019-03-29T15:21:06.009Z] 15:21:06 INFO - GECKO(4718) | #16: mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:303]
[task 2019-03-29T15:21:06.009Z] 15:21:06 INFO -
[task 2019-03-29T15:21:06.018Z] 15:21:06 INFO - GECKO(4718) | #17: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:315]
[task 2019-03-29T15:21:06.018Z] 15:21:06 INFO -
[task 2019-03-29T15:21:06.019Z] 15:21:06 INFO - GECKO(4718) | #18: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:584]

Flags: needinfo?(amarchesini)
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7cc45cebde1c
Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug

https://hg.mozilla.org/mozilla-central/rev/7cc45cebde1c

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → amarchesini
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: